Bugzilla – Attachment 186138 Details for
Bug 40663
Package GD::Barcode::QRcode@2.01
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40663: Revert "Bug 40490: Remove warnings from GD::Barcode::QRcode - U24"
Bug-40663-Revert-Bug-40490-Remove-warnings-from-GD.patch (text/plain), 2.52 KB, created by
Jonathan Druart
on 2025-09-04 09:55:23 UTC
(
hide
)
Description:
Bug 40663: Revert "Bug 40490: Remove warnings from GD::Barcode::QRcode - U24"
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-09-04 09:55:23 UTC
Size:
2.52 KB
patch
obsolete
>From cf4a0dc5e168e3fa391f3164d6fcd078765f5543 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 4 Sep 2025 11:54:59 +0200 >Subject: [PATCH] Bug 40663: Revert "Bug 40490: Remove warnings from > GD::Barcode::QRcode - U24" > >This reverts commit fd6ceb6b244bf65d8cf0c1144a9a903490fdaadf. >--- > t/db_dependent/api/v1/two_factor_auth.t | 28 ++----------------------- > 1 file changed, 2 insertions(+), 26 deletions(-) > >diff --git a/t/db_dependent/api/v1/two_factor_auth.t b/t/db_dependent/api/v1/two_factor_auth.t >index 175e6e9529d..ddb9178e3a2 100755 >--- a/t/db_dependent/api/v1/two_factor_auth.t >+++ b/t/db_dependent/api/v1/two_factor_auth.t >@@ -90,19 +90,7 @@ subtest 'registration and verification' => sub { > $tx = $t->ua->build_tx( POST => "/api/v1/auth/two-factor/registration" ); > $tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); > $tx->req->env( { REMOTE_ADDR => $remote_address } ); >- { >- # Ignore the following warning >- # Use of uninitialized value $aMask[1383] in bitwise xor (^) at /usr/local/share/perl/5.36.0/GD/Barcode/QRcode.pm line 217. >- # We do not want to expect it (using Test::Warn): it is a bug from GD::Barcode >- local $SIG{__WARN__} = sub { }; >- my $dup_err; >- local *STDERR; >- open STDERR, ">>", \$dup_err; >- >- $t->request_ok($tx)->status_is(201); >- >- close STDERR; >- } >+ $t->request_ok($tx)->status_is(201); > my $secret32 = $t->tx->res->json->{secret32}; > > $tx = $t->ua->build_tx( POST => "/api/v1/auth/two-factor/registration/verification" ); >@@ -132,19 +120,7 @@ subtest 'registration and verification' => sub { > $tx = $t->ua->build_tx( POST => "/api/v1/auth/two-factor/registration" ); > $tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); > $tx->req->env( { REMOTE_ADDR => $remote_address } ); >- { >- # Ignore the following warning >- # Use of uninitialized value $aMask[1383] in bitwise xor (^) at /usr/local/share/perl/5.36.0/GD/Barcode/QRcode.pm line 217. >- # We do not want to expect it (using Test::Warn): it is a bug from GD::Barcode >- local $SIG{__WARN__} = sub { }; >- my $dup_err; >- local *STDERR; >- open STDERR, ">>", \$dup_err; >- >- $t->request_ok($tx)->status_is(201); >- >- close STDERR; >- } >+ $t->request_ok($tx)->status_is(201); > $secret32 = $t->tx->res->json->{secret32}; > > $auth = Koha::Auth::TwoFactorAuth->new( { patron => $patron, secret32 => $secret32 } ); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40663
:
185513
|
185999
|
186138
|
186241
|
186242