Bugzilla – Attachment 186154 Details for
Bug 40614
Invalid markup in cookie consent modal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40614: Invalid markup in cookie consent modal
Bug-40614-Invalid-markup-in-cookie-consent-modal.patch (text/plain), 1.66 KB, created by
Noah Tremblay
on 2025-09-04 14:04:34 UTC
(
hide
)
Description:
Bug 40614: Invalid markup in cookie consent modal
Filename:
MIME Type:
Creator:
Noah Tremblay
Created:
2025-09-04 14:04:34 UTC
Size:
1.66 KB
patch
obsolete
>From d5e22f8b00e8dc2e86a080056f9895e261d8fb1d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 7 Aug 2025 16:22:41 +0000 >Subject: [PATCH] Bug 40614: Invalid markup in cookie consent modal > >This patch corrects a minor markup error in the OPAC's cookie consent >modal, removing a "type" attribute from an <a> tag. > >To test apply the patch and make sure you have the CookieConsent system >preference enabled. > >- Go to the OPAC. You should see a cookie consent banner across the > bottom of the page. >- Click "More information." >- Click "Cancel" in the modal window. The modal should close. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: noah <noah@inlibro.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 18e38980f2..4535b9a897 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -586,7 +586,7 @@ > <button type="button" class="btn btn-primary consentAcceptAll">Accept all cookies</button> > <button type="button" class="btn btn-warning" id="consentAcceptSelected">Accept selected non-essential cookies</button> > [% END %] >- <a type="button" href="#" class="btn btn-secondary consentCloseModal">Cancel</a> >+ <a href="#" class="btn btn-secondary consentCloseModal">Cancel</a> > </div> > </div> > </div> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40614
:
185232
|
186154
|
186607
|
186614