Bugzilla – Attachment 186188 Details for
Bug 40755
Hold cancellation requests cause error 500 on holds waiting page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40755: Fix typo in waiting_holds.inc
Bug-40755-Fix-typo-in-waitingholdsinc.patch (text/plain), 2.71 KB, created by
Jonathan Druart
on 2025-09-05 03:45:13 UTC
(
hide
)
Description:
Bug 40755: Fix typo in waiting_holds.inc
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-09-05 03:45:13 UTC
Size:
2.71 KB
patch
obsolete
>From 68b6ab2285af6d7965c91e45f1e14fe99bb8a5d3 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Thu, 4 Sep 2025 09:37:37 -0400 >Subject: [PATCH] Bug 40755: Fix typo in waiting_holds.inc > >Fix a typo that caused an error 500 on the holds awaiting pickup page >when there are holds with cancellation requests. > >To test: >1. Enable hold cancellation requests from the OPAC > i. Go to Administration > Circulation and Fines rules > ii. In the "Default waiting hold cancellation policy" section, add the rule: > All / All / Yes >2. Place at least two holds for pickup at the logged-in library (for ease of testing, place both holds for the same patron) >3. Check in items for both holds and confirm to set holds to Waiting >4. Log into the OPAC as the patron from step 2 >5. Go to the patron's holds tab and request cancellation for both holds >6. In the staff interface, go to Circulation > Holds awaiting pickup >==> Error 500! :( >7. Apply patch and refresh the page >==> The page loads! :) > >Bonus testing (KTD only): >1. Edit one of the cancellation request dates, so that they are not both > the same date: > ktd --shell > koha-mysql kohadev > SELECT * FROM hold_cancellation_requests; > UPDATE hold_cancellation_requests SET creation_date=<date> WHERE hold_cancellation_request_id = <id>; >2. Refresh the Holds awaiting pickup page again, and switch to the Holds > with cancellation requests tab >3. Sort by hold cancellation request date and confirm the sorting works > correctly > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >index 97a9a72fcf7..2ba57981f4f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >@@ -30,7 +30,7 @@ > <td data-order="[% reserveloo.reservedate | html %]"><span>[% reserveloo.reservedate | $KohaDates %]</span></td> > [% IF table_name == 'holdscr' %] > [% IF reserveloo.cancellation_requests.count %] >- <td data-order="[% cancellation_request.0.creation_date | html %]"> >+ <td data-order="[% cancellation_requests.0.creation_date | html %]"> > [% FOREACH cancellation_request IN reserveloo.cancellation_requests %] > <span>[% cancellation_request.creation_date | $KohaDates %]</span> > [% END %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40755
:
186153
|
186167
| 186188