Bugzilla – Attachment 186278 Details for
Bug 30515
Move Overdue transports to patron messaging preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30515: Use print if the patron's preference is empty
Bug-30515-Use-print-if-the-patrons-preference-is-e.patch (text/plain), 2.17 KB, created by
Jonathan Druart
on 2025-09-09 09:47:46 UTC
(
hide
)
Description:
Bug 30515: Use print if the patron's preference is empty
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-09-09 09:47:46 UTC
Size:
2.17 KB
patch
obsolete
>From 88355c9cd241004bdd0b0f2a7994667b3e9e039f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 9 Sep 2025 11:45:21 +0200 >Subject: [PATCH] Bug 30515: Use print if the patron's preference is empty > >If the patron has not selected a transport type we still want to print. >ie. the patrons cannot totally opt out. >--- > misc/cronjobs/overdue_notices.pl | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index ea5d9e57f83..d5672a1f329 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -755,14 +755,23 @@ END_SQL > if ( $patronpref && $patronpref->{'transports'} ) { > @message_transport_types = keys %{ $patronpref->{'transports'} }; > } >- } else { >- my @message_transport_types = >- @{ GetOverdueMessageTransportTypes( $branchcode, $overdue_rules->{categorycode}, $i ) }; >- @message_transport_types = >- @{ GetOverdueMessageTransportTypes( q{}, $overdue_rules->{categorycode}, $i ) } >- unless @message_transport_types; > } > >+ use Data::Printer colored => 1; >+ warn p @message_transport_types; >+ @message_transport_types = >+ @{ GetOverdueMessageTransportTypes( $branchcode, $overdue_rules->{categorycode}, $i ) } >+ unless @message_transport_types; >+ >+ use Data::Printer colored => 1; >+ warn p @message_transport_types; >+ @message_transport_types = >+ @{ GetOverdueMessageTransportTypes( q{}, $overdue_rules->{categorycode}, $i ) } >+ unless @message_transport_types; >+ >+ use Data::Printer colored => 1; >+ warn p @message_transport_types; >+ > my $print_sent = 0; # A print notice is not yet sent for this patron > for my $mtt (@message_transport_types) { > next if $mtt eq 'itiva'; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30515
:
163564
|
163573
|
163574
|
178276
|
178548
|
178549
|
178550
|
186143
|
186144
|
186145
|
186146
|
186147
|
186258
|
186272
|
186278
|
186280
|
186287
|
186288
|
186289
|
186290
|
186291
|
186292
|
186293
|
186294
|
186295