Bugzilla – Attachment 186292 Details for
Bug 30515
Move Overdue transports to patron messaging preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30515: fix GetMessagingPreferences call
Bug-30515-fix-GetMessagingPreferences-call.patch (text/plain), 2.26 KB, created by
Philip Orr
on 2025-09-09 12:54:14 UTC
(
hide
)
Description:
Bug 30515: fix GetMessagingPreferences call
Filename:
MIME Type:
Creator:
Philip Orr
Created:
2025-09-09 12:54:14 UTC
Size:
2.26 KB
patch
obsolete
>From 905e7a9b7a11406210f00b534637dcf0f16b25a5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 8 Sep 2025 15:36:17 +0200 >Subject: [PATCH] Bug 30515: fix GetMessagingPreferences call > >It's not exported > >Signed-off-by: krimsonkharne <philip.orr@posteo.de> >--- > misc/cronjobs/overdue_notices.pl | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index b8acfec875..e797710811 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -749,18 +749,17 @@ END_SQL > $sth2->finish; > > my @message_transport_types; >- if (C4::Context->preference('UsePatronPreferencesForOverdueNotices')) { >- my $patronpref = GetMessagingPreferences( >- { borrowernumber => $borrowernumber, message_name => "Overdue$i"}); >- if ($patronpref && $patronpref->{'transports'}) { >- @message_transport_types = keys %{$patronpref->{'transports'}}; >+ if ( C4::Context->preference('UsePatronPreferencesForOverdueNotices') ) { >+ my $patronpref = C4::Members::Messaging::GetMessagingPreferences( >+ { borrowernumber => $borrowernumber, message_name => "Overdue$i" } ); >+ if ( $patronpref && $patronpref->{'transports'} ) { >+ @message_transport_types = keys %{ $patronpref->{'transports'} }; > } > my $print_behavior = C4::Context->preference('UsePatronPreferencesForOverdueNoticesPrint'); >- if ( >- $print_behavior eq 'always' || >- $print_behavior eq 'fallback' && !@message_transport_types >- ) { >- unshift(@message_transport_types, 'shift'); >+ if ( $print_behavior eq 'always' >+ || $print_behavior eq 'fallback' && !@message_transport_types ) >+ { >+ unshift( @message_transport_types, 'shift' ); > } > } else { > my @message_transport_types = >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30515
:
163564
|
163573
|
163574
|
178276
|
178548
|
178549
|
178550
|
186143
|
186144
|
186145
|
186146
|
186147
|
186258
|
186272
|
186278
|
186280
|
186287
|
186288
|
186289
|
186290
|
186291
| 186292 |
186293
|
186294
|
186295