Bugzilla – Attachment 186339 Details for
Bug 3492
Move hold fee setting into circulation rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 3492: Remove from patron categories admin
Bug-3492-Remove-from-patron-categories-admin.patch (text/plain), 6.22 KB, created by
Martin Renvoize (ashimema)
on 2025-09-10 21:24:13 UTC
(
hide
)
Description:
Bug 3492: Remove from patron categories admin
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-09-10 21:24:13 UTC
Size:
6.22 KB
patch
obsolete
>From 622b91940428f8c585d41115a6cc0b9657a1a38c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Tue, 9 Sep 2025 09:56:01 +0100 >Subject: [PATCH] Bug 3492: Remove from patron categories admin > >--- > admin/categories.pl | 3 --- > .../intranet-tmpl/prog/en/modules/admin/categories.tt | 11 ----------- > koha-tmpl/intranet-tmpl/prog/js/categories.js | 3 --- > koha-tmpl/intranet-tmpl/prog/js/onboarding.js | 3 --- > 4 files changed, 20 deletions(-) > >diff --git a/admin/categories.pl b/admin/categories.pl >index 04b5e5cc024..f536eb55da7 100755 >--- a/admin/categories.pl >+++ b/admin/categories.pl >@@ -63,7 +63,6 @@ if ( $op eq 'add_form' ) { > my $upperagelimit = $input->param('upperagelimit'); > my $dateofbirthrequired = $input->param('dateofbirthrequired'); > my $enrolmentfee = $input->param('enrolmentfee'); >- my $reservefee = $input->param('reservefee'); > my $hidelostitems = $input->param('hidelostitems'); > my $overduenoticerequired = $input->param('overduenoticerequired'); > my $category_type = $input->param('category_type'); >@@ -103,7 +102,6 @@ if ( $op eq 'add_form' ) { > $category->upperagelimit($upperagelimit); > $category->dateofbirthrequired($dateofbirthrequired); > $category->enrolmentfee($enrolmentfee); >- $category->reservefee($reservefee); > $category->hidelostitems($hidelostitems); > $category->overduenoticerequired($overduenoticerequired); > $category->category_type($category_type); >@@ -142,7 +140,6 @@ if ( $op eq 'add_form' ) { > upperagelimit => $upperagelimit, > dateofbirthrequired => $dateofbirthrequired, > enrolmentfee => $enrolmentfee, >- reservefee => $reservefee, > hidelostitems => $hidelostitems, > overduenoticerequired => $overduenoticerequired, > category_type => $category_type, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >index e91ba21feb3..c0a66967ffb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >@@ -204,10 +204,6 @@ > [% END %] > </select> > </li> >- <li> >- <label for="reservefee">Hold fee: </label> >- <input type="text" name="reservefee" id="reservefee" size="6" value="[% category.reservefee | $Price on_editing => 1 %]" /> >- </li> > <li> > <label for="category_type" class="required">Category type: </label> > <select name="category_type" id="category_type"> >@@ -571,7 +567,6 @@ > <tr><th scope="row">Enrollment fee: </th><td>[% category.enrolmentfee | $Price %]</td></tr> > <tr><th scope="row">Receives overdue notices: </th><td>[% IF category. overduenoticerequired %]Yes[% ELSE %]No[% END %]</td></tr> > <tr><th scope="row">Lost items in staff interface:</th><td>[% IF category.hidelostitems %]Hidden by default[% ELSE %]Shown[% END %]</td></tr> >- <tr><th scope="row">Hold fee: </th><td>[% category.reservefee | $Price %]</td></tr> > > [% IF ( Koha.Preference('CheckPrevCheckout') == 'softyes' || Koha.Preference('CheckPrevCheckout') == 'softno' ) %] > <tr> >@@ -652,7 +647,6 @@ > <th scope="col" data-colname="enrollment_fee">Enrollment fee</th> > <th scope="col" data-colname="overdue">Overdue</th> > <th scope="col" data-colname="lost_items">Lost items</th> >- <th scope="col" data-colname="hold_fee">Hold fee</th> > [% IF ( EnhancedMessagingPreferences ) %] > <th scope="col" data-colname="messaging">Messaging</th> > [% END %] >@@ -726,11 +720,6 @@ > [% END %] > <td>[% IF ( category.overduenoticerequired ) %]Yes[% ELSE %]No[% END %]</td> > <td>[% IF ( category.hidelostitems ) %]Hidden[% ELSE %]Shown[% END %]</td> >- [% IF (category.reservefee > 0) %] >- <td>[% category.reservefee | $Price %]</td> >- [% ELSE %] >- <td>-</td> >- [% END %] > [% IF Koha.Preference('EnhancedMessagingPreferences') %] > <td style="white-space: nowrap; font-size:80%;"> > [% SET default_messaging = category.default_messaging %] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/categories.js b/koha-tmpl/intranet-tmpl/prog/js/categories.js >index 72835e1f187..3bd64afc445 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/categories.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/categories.js >@@ -94,9 +94,6 @@ $(document).ready(function () { > enrolmentfee: { > number: true, > }, >- reservefee: { >- number: true, >- }, > category_type: { > required: true, > }, >diff --git a/koha-tmpl/intranet-tmpl/prog/js/onboarding.js b/koha-tmpl/intranet-tmpl/prog/js/onboarding.js >index 31937eca685..d0fd4990600 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/onboarding.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/onboarding.js >@@ -141,9 +141,6 @@ $(document).ready(function () { > enrolmentfee: { > number: true, > }, >- reservefee: { >- number: true, >- }, > category_type: { > required: true, > }, >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3492
:
1356
|
1357
|
119909
|
186336
|
186337
|
186338
|
186339
|
186340
|
186361
|
186691
|
186692
|
186693
|
186694
|
186695
|
186696
|
186711
|
186712
|
186713
|
186714
|
186715
|
186716