Bugzilla – Attachment 186384 Details for
Bug 40799
Loading spinner not removed because .cover-slider is now used instead of .cover-slides
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides
Bug-40799-Loading-spinner-not-removed-because-cove.patch (text/plain), 1.61 KB, created by
Hammat wele
on 2025-09-12 12:29:18 UTC
(
hide
)
Description:
Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides
Filename:
MIME Type:
Creator:
Hammat wele
Created:
2025-09-12 12:29:18 UTC
Size:
1.61 KB
patch
obsolete
>From 079eaf8ef29bac4987354e57e8255aa4fb2afd23 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Fri, 12 Sep 2025 12:23:44 +0000 >Subject: [PATCH] Bug 40799: Loading spinner not removed because .cover-slider > is now used instead of .cover-slides > >After Bug 32642, the spinner on cover images is hidden by verify_cover_images() which removes the .cover-slides class from the cover container. > >However, Bug 33848 modified the SCSS so that the spinner is now triggered by .cover-slider instead of .cover-slides. > >As a result, the spinner is never removed, because verify_cover_images() only removes .cover-slides. > >Test plan > >1- Follow the test plan from Bug 32642. > ==> The spinner is displayed and never disappears. >2. Reload the page. >==> The spinner disappears once the cover image is loaded. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 086a42e6864..3e42ea1cda6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1734,7 +1734,7 @@ > $(coverSlide).find("img").each( function() { > if( !this.complete || this.naturalHeight == 0 ) check_complete = 0; > }); >- if( check_complete ) $(coverSlide).removeClass('cover-slides'); >+ if( check_complete ) $(coverSlide).removeClass('cover-slider'); > } > }); > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40799
: 186384