Bugzilla – Attachment 186385 Details for
Bug 40800
TransferArrived needlessly triggers alerts in SIP
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40800: SIP checkin incorrectly triggering alerts on successful transfer completion
Bug-40800-SIP-checkin-incorrectly-triggering-alert.patch (text/plain), 2.12 KB, created by
Martin Renvoize (ashimema)
on 2025-09-12 14:21:47 UTC
(
hide
)
Description:
Bug 40800: SIP checkin incorrectly triggering alerts on successful transfer completion
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-09-12 14:21:47 UTC
Size:
2.12 KB
patch
obsolete
>From 6a3ecea4d9a94c72666908df18525d4583639dc3 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 12 Sep 2025 15:08:54 +0100 >Subject: [PATCH] Bug 40800: SIP checkin incorrectly triggering alerts on > successful transfer completion > >When an item is checked in via SIP2 at the correct target branch after a >transfer, the system was incorrectly triggering an alert flag. This occurred >because the TransferArrived message was not being filtered out for accounts >with checked_in_ok="1", causing the alert logic to treat successful transfer >completion as a failure condition. > >The TransferArrived message indicates successful transfer completion and is >purely informational - it should not trigger SIP alerts. This fix ensures >that TransferArrived messages are filtered out before alert evaluation, >preventing false positive alerts on successful operations. > >Test Plan: >1. Set up a SIP2 account with checked_in_ok="1" in SIPconfig.xml >2. Via staff client, check out an item to a patron >3. Return the item to a different branch to trigger a transfer >4. Use misc/sip_cli_emulator.pl to check in the item at the target branch >5. Verify SIP response shows alert flag 'N' (no alert) instead of 'Y' >6. Test wrong branch checkin still shows alert flag 'Y' with CV04 type > >Before: Transfer completion at correct branch incorrectly shows alert='Y' >After: Transfer completion at correct branch correctly shows alert='N' >--- > C4/SIP/ILS/Transaction/Checkin.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index 94087723a84..bd3880bc3fe 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -122,6 +122,9 @@ sub do_checkin { > ( $return, $messages, $issue, $borrower ) = AddReturn( $barcode, $branch, undef, $return_date ) > unless $human_required || $checkin_blocked_by_holds; > >+ # TransferArrived is informational and should not trigger alerts >+ delete $messages->{TransferArrived}; >+ > if ($checked_in_ok) { > delete $messages->{ItemLocationUpdated}; > delete $messages->{NotIssued}; >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40800
: 186385 |
186386