Bugzilla – Attachment 186396 Details for
Bug 37622
"location" header is set for non-POST routes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37622: Adjust 'location' header test
Bug-37622-Adjust-location-header-test.patch (text/plain), 3.68 KB, created by
Jonathan Druart
on 2025-09-15 08:42:36 UTC
(
hide
)
Description:
Bug 37622: Adjust 'location' header test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-09-15 08:42:36 UTC
Size:
3.68 KB
patch
obsolete
>From 73c71cdbb5ff3a6f084ea4e200a883b2fcc95da0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 15 Sep 2025 10:39:41 +0200 >Subject: [PATCH] Bug 37622: Adjust 'location' header test > >We were ignoring whole files and parsing the whole file to check if >location and 201 were together. It's way better to check per subroutine. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > xt/api.t | 53 +++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 35 insertions(+), 18 deletions(-) > >diff --git a/xt/api.t b/xt/api.t >index 3aa2e7f90fc..f04ea41d3f9 100755 >--- a/xt/api.t >+++ b/xt/api.t >@@ -19,14 +19,15 @@ use Test::NoWarnings; > > use Test::Mojo; > use Data::Dumper; >-use Koha::Database; >- >+use PPI; > use FindBin(); > use IPC::Cmd qw(can_run); > use List::MoreUtils qw(any); > use File::Slurp qw(read_file); > use YAML::XS qw(LoadFile); > >+use Koha::Database; >+ > my $t = Test::Mojo->new('Koha::REST::V1'); > my $spec = $t->get_ok( '/api/v1/', 'Correctly fetched the spec' )->tx->res->json; > >@@ -176,24 +177,40 @@ subtest '400 response tests' => sub { > }; > > subtest 'POST (201) have location header' => sub { >- my @files = `git ls-files 'Koha/REST/V1/**/*.pm'`; >- plan tests => scalar @files; >- my @exceptions = qw( >- Koha/REST/V1/Auth/Password.pm >- Koha/REST/V1/Preservation/WaitingList.pm >- ); >+ my @files = `git ls-files 'Koha/REST/V1/**/*.pm'`; >+ my $exceptions = { >+ 'Koha/REST/V1/Auth/Password.pm' => [qw(validate)], >+ 'Koha/REST/V1/ERM/EHoldings/Titles/Local.pm' => [qw(import_from_list import_from_kbart_file)], >+ 'Koha/REST/V1/Preservation/Trains.pm' => [qw(add_item add_items copy_item)], >+ 'Koha/REST/V1/Preservation/WaitingList.pm' => [qw(add_items)], >+ }; > foreach my $file (@files) { > chomp $file; >- my $content = read_file($file); >- if ( grep { $file eq $_ } @exceptions ) { >- pass("$file is skipped - exception"); >- } elsif ( $content !~ /status\s*=>\s*201/s ) { >- pass("$file does not seem to have a POST endpoint"); >- } elsif ( $content =~ /\$c->res->headers->location\(.*?\);\s*return\s+\$c->render\s*\(\s*status\s*=>\s*201,/s ) >- { >- pass("$file contains the location header"); >- } else { >- fail("$file does not contain the location header"); >+ my $doc = PPI::Document->new($file); >+ my $subs = $doc->find( sub { $_[1]->isa('PPI::Statement::Sub') } ); >+ >+ foreach my $sub (@$subs) { >+ my $name = $sub->name; >+ if ( exists $exceptions->{$file} && grep { $name eq $_ } @{ $exceptions->{$file} } ) { >+ pass("$file:$name is skipped - exception"); >+ next; >+ } >+ >+ my $content = $sub->content; >+ >+ if ( $content =~ /\$c->res->headers->location\(.*?\);\s*return\s+\$c->render\s*\(\s*status\s*=>\s*201,/s ) { >+ pass("$file:$name contains the location header"); >+ } elsif ( $content =~ /\$c->res->headers->location\(.*?\);/ ) { >+ if ( $content !~ /return\s+\$c->render\s*\(\s*status\s*=>\s*201,/ ) { >+ fail("$file:$name has the location header without 201"); >+ } else { >+ fail("$file:$name has the location header and 201, but other statements should be between them"); >+ } >+ } elsif ( $content !~ /status\s*=>\s*201/s ) { >+ pass("$file:$name does not seem to have a POST endpoint"); >+ } else { >+ fail("$file:$name does not contain the location header"); >+ } > } > } > }; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37622
:
170248
|
176567
|
180743
|
186395
|
186396
|
186397
|
186398
|
186879
|
186880
|
186881
|
186882