Bugzilla – Attachment 186400 Details for
Bug 40807
Quick add form does not include 'username' when it is included in BorrowerMandatoryFields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40807: fix: username field in quick add form
Bug-40807-fix-username-field-in-quick-add-form.patch (text/plain), 3.02 KB, created by
ChloƩ Zermatten
on 2025-09-15 10:15:19 UTC
(
hide
)
Description:
Bug 40807: fix: username field in quick add form
Filename:
MIME Type:
Creator:
ChloƩ Zermatten
Created:
2025-09-15 10:15:19 UTC
Size:
3.02 KB
patch
obsolete
>From aba61cdeefdc4f68c259bfab4af1828434584425 Mon Sep 17 00:00:00 2001 >From: Chloe Zermatten <chloe.zermatten@openfifth.co.uk> >Date: Mon, 15 Sep 2025 10:05:19 +0000 >Subject: [PATCH] Bug 40807: fix: username field in quick add form > >The username field would not appear in the quick add form despite being marked as required in BorrowerMandatoryField. >This was due the interaction between a change introduced by Bug 38459 and the dummy input for the username field. > >This patch moves the dummy input so that the true input is the last child that the change in Bug 38459 targets. >This allows the username field to appear when added to BorrowerMandatoryField. > >Test plan: >0. (Before applying the patch, follow the replication tests as in the comment above.) >1. Login to the Koha staff interface >2. Search system preferences for BorrowerMandatoryField >3. Toggle on Username (userid) so it is added to the list of fields and save your changes. >4. Navigate to /cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=PT, notice that username still shows and is marked as required >5. Navigate to /cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=PT&quickadd=true, notice that the username field does show. >--- > .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index a4cee866f38..fc6f59d4fb8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1162,6 +1162,9 @@ > <li> > <label for="userid" [% IF mandatoryuserid %]class="required"[% END %]> Username: </label> > >+ [%# Dummy input to avoid Firefox from using userid/password saved for authentication %] >+ <input type="text" disabled="disabled" style="display:none" /> >+ > [% IF ( NoUpdateLogin ) %] > [% IF ( op == 'duplicate' ) %] > <input type="text" id="userid" name="userid" size="20" disabled="disabled" /> >@@ -1176,9 +1179,6 @@ > [% END %] > [% END # /IF ( NoUpdateLogin ) %] > >- [%# Dummy input to avoid Firefox from using userid/password saved for authentication %] >- <input type="text" disabled="disabled" style="display:none" /> >- > [% IF ( mandatoryuserid ) %] > <span class="required">Required</span> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40807
: 186400