Bugzilla – Attachment 186505 Details for
Bug 30568
Make patron name fields more flexible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30568: Add classes to component name parts in intranet
Bug-30568-Add-classes-to-component-name-parts-in-i.patch (text/plain), 6.28 KB, created by
Lucas Gass (lukeg)
on 2025-09-16 17:58:30 UTC
(
hide
)
Description:
Bug 30568: Add classes to component name parts in intranet
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-09-16 17:58:30 UTC
Size:
6.28 KB
patch
obsolete
>From 75f9cdf2fee16240a1def099bdf6d28c51e0cf10 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Tue, 10 Dec 2024 18:28:17 +0000 >Subject: [PATCH] Bug 30568: Add classes to component name parts in intranet > >to test: >1 - have a patron with all name parts >2 - load pages with a variety of name displays, confirm lack of classes >3 - apply patch >4 - reload pages from step 2, confirm there are now classes *except for where the name is called with no_html, like a page title > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../prog/en/includes/patron-title.inc | 49 +++++++++++++++++-- > .../bootstrap/en/includes/patron-title.inc | 4 +- > 2 files changed, 47 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >index e25bc030414..4384afd73b7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >@@ -61,13 +61,54 @@ > [%- END -%] > [%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] > [%- IF link_to == 'circulation_reserves' -%] >- <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#reserves">[%- PROCESS display_patron_name -%]</a> >+ <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#reserves"> </a> > [%- ELSIF link_to == 'circulation_recalls' -%] >- <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#recalls">[%- PROCESS display_patron_name -%]</a> >+ <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#recalls"> </a> > [%- ELSIF link_to == 'members_pay' -%] >- <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[%- patron.borrowernumber | uri -%]">[%- PROCESS display_patron_name -%]</a> >+ <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[%- patron.borrowernumber | uri -%]"> </a> > [%- ELSE -%] >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[%- data.borrowernumber | uri -%]">[%- PROCESS display_patron_name -%]</a> >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[%- data.borrowernumber | uri -%]"> </a> >+ [%- END -%] >+[%- END -%] >+[%- IF display_patron_name -%] >+ [%- IF no_html -%] >+ [%- IF data.category_type == 'I' -%] >+ [%- data.surname | html -%] >+ [%- IF data.othernames -%]([%- data.othernames | html -%])[%- END -%] >+ [%- ELSIF invert_name -%] >+ [%- data.title | $raw -%][%- data.surname | html -%][%- IF ( data.preferred_name ) -%], [% data.preferred_name | html -%][%- END -%][%- IF data.middle_name -%][% data.middle_name | html -%][%- END -%][%- IF data.othernames -%]([%- data.othernames | html -%])[%- END -%] >+ [%- ELSE -%] >+ [%- data.title | $raw -%][%- data.preferred_name | html %][%- IF data.middle_name -%][% data.middle_name | html -%][%- END -%][%- IF data.othernames -%]([%- data.othernames | html -%])[%- END -%] >+ [% data.surname | html -%] >+ [%- END -%] >+ [%- IF display_cardnumber AND data.cardnumber -%]([%- data.cardnumber | html -%])[%- END -%] >+ [%- ELSE -%] >+ [%- IF data.category_type == 'I' -%] >+ <span class="surname">[%- data.surname | html -%]</span> [%- IF data.othernames -%]<span class="othernames">([%- data.othernames | html -%])</span>[%- END -%] >+ [%- ELSIF invert_name -%] >+ [%- data.title | $raw -%]<span class="surname">[%- data.surname | html -%]</span>[%- IF ( data.preferred_name ) -%] >+ , <span class="preferred_name">[% data.preferred_name | html -%]</span> >+ [%- END -%][%- IF data.middle_name -%]<span class="middle_name">[% data.middle_name | html -%]</span>[%- END -%][%- IF data.othernames -%] >+ <span class="othernames">([%- data.othernames | html -%])</span> >+ [%- END -%] >+ [%- ELSE -%] >+ [%- data.title | $raw -%]<span class="preferred_name">[%- data.preferred_name | html %]</span>[%- IF data.middle_name -%]<span class="middle_name">[% data.middle_name | html -%]</span>[%- END -%][%- IF data.othernames -%] >+ <span class="othernames">([%- data.othernames | html -%])</span> >+ [%- END -%] <span class="surname">[% data.surname | html -%]</span> >+ [%- END -%] >+ [%- IF display_cardnumber AND data.cardnumber -%]<span class="cardnumber">([%- data.cardnumber | html -%])</span>[%- END -%] >+ [%- END -%] >+[%- ELSIF display_cardnumber -%] >+ [%- IF no_html -%] >+ [%- IF data.cardnumber -%] >+ [%# FIXME Cardnumber should always be defined, right? -%] >+ [%- data.cardnumber | html -%] >+ [%- END -%] >+ [%- ELSE -%] >+ [%- IF data.cardnumber -%] >+ [%# FIXME Cardnumber should always be defined, right? -%] >+ <span class="cardnumber">[%- data.cardnumber | html -%]</span> >+ [%- END -%] > [%- END -%] > [%- ELSE -%] > [%- PROCESS display_patron_name -%] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc >index c506504e6fe..66ca272c675 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc >@@ -1,8 +1,8 @@ > [%- IF patron.category.category_type == 'I' -%] >- <span class="surname">[% patron.surname | html %]</span>[% IF patron.othernames %] <span class="othername">([% patron.othernames | html %])</span> [%- END -%] >+ <span class="surname">[% patron.surname | html %]</span>[% IF patron.othernames %]<span class="othername">([% patron.othernames | html %])</span>[%- END -%] > [%- ELSE -%] > [%- IF patron.title -%] > <span class="patron-title">[% patron.title | html %]</span> > [%- END -%] >- <span class="preferred_name">[% patron.preferred_name | html %]</span> <span class="middle_name">[% patron.middle_name | html %]</span> <span class="surname">[% patron.surname | html %] >+ <span class="preferred_name">[% patron.preferred_name | html %]</span> <span class="middle_name">[% patron.middle_name | html %]</span> <span class="surname">[% patron.surname | html %] </span> > [%- END -%] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30568
:
175338
|
175351
|
175365
|
175910
|
175911
|
186504
|
186505
|
187420
|
187421
|
187494
|
187495
|
187659
|
187660
|
187704
|
187740
|
187741
|
187742
|
187743
|
187785
|
187786
|
187787
|
187788
|
188391