Bugzilla – Attachment 186717 Details for
Bug 40704
When item is deleted, title disappears from reading history creating a useless entry
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40704: Display 'item deleted' in checkout history
Bug-40704-Display-item-deleted-in-checkout-history.patch (text/plain), 3.25 KB, created by
Jonathan Druart
on 2025-09-22 14:14:33 UTC
(
hide
)
Description:
Bug 40704: Display 'item deleted' in checkout history
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-09-22 14:14:33 UTC
Size:
3.25 KB
patch
obsolete
>From 6a3c27fcdcc4254490fdab6db48419ae00bc6354 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 22 Sep 2025 16:13:44 +0200 >Subject: [PATCH] Bug 40704: Display 'item deleted' in checkout history > >Instead of an empty line we can show that the item has been deleted. >--- > .../prog/en/modules/members/readingrec.tt | 8 +++++++- > .../bootstrap/en/modules/opac-readingrecord.tt | 12 ++++++++---- > 2 files changed, 15 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >index 26c99e59f4b..f0d600463e5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >@@ -92,7 +92,13 @@ > [% issuetype | html %] > </td> > <td data-order="[% checkout.timestamp | html %]"> [% checkout.timestamp | $KohaDates with_hours => 1 %] </td> >- <td> [% INCLUDE 'biblio-title.inc' biblio=biblio link = 1 %] </td> >+ <td> >+ [% IF item %] >+ [% INCLUDE 'biblio-title.inc' biblio=biblio link = 1 %] >+ [% ELSE %] >+ <span>The item has been deleted</span> >+ [% END %] >+ </td> > > <td>[% biblio.author | html %]</td> > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index 85f083cecbe..74745dad127 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -185,10 +185,14 @@ > [% END %] > </td> > <td> >- [% INCLUDE 'biblio-title.inc' biblio=biblio, link => 1 %] >- [% IF ( Koha.Preference( 'OpacStarRatings' ) == 'all' ) %] >- [% SET ratings = {ratings => biblio.ratings, itemnumber => item.itemnumber, biblionumber => biblio.biblionumber, my_rating => biblio.ratings.search( borrowernumber => logged_in_user.borrowernumber ).next } %] >- [% INCLUDE 'user-star-ratings.inc' item=ratings %] >+ [% IF item %] >+ [% INCLUDE 'biblio-title.inc' biblio=biblio, link => 1 %] >+ [% IF ( Koha.Preference( 'OpacStarRatings' ) == 'all' ) %] >+ [% SET ratings = {ratings => biblio.ratings, itemnumber => item.itemnumber, biblionumber => biblio.biblionumber, my_rating => biblio.ratings.search( borrowernumber => logged_in_user.borrowernumber ).next } %] >+ [% INCLUDE 'user-star-ratings.inc' item=ratings %] >+ [% END %] >+ [% ELSE %] >+ <span>The item has been deleted</span> > [% END %] > </td> > <td>[% biblio.author | html %]</td> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40704
: 186717 |
186728
|
186784
|
186785
|
186786