Bugzilla – Attachment 186896 Details for
Bug 40593
Can't search all columns in Acquisitions Suggestions table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Works great! QA tool is also happy. Thanks!
Bug-40593-Restore-searchable-columns-to-the-sugges.patch (text/plain), 3.81 KB, created by
Laura Escamilla
on 2025-09-24 15:42:35 UTC
(
hide
)
Description:
Works great! QA tool is also happy. Thanks!
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2025-09-24 15:42:35 UTC
Size:
3.81 KB
patch
obsolete
>From 81fd71d076e18ceaa3c2aa7d6fc635ce34c4eb49 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Tue, 19 Aug 2025 10:27:59 +0100 >Subject: [PATCH] Bug 40593: Restore searchable columns to the suggestions > table > >This patch adds search functionality to the following columns: Suggester category, Patron reason, Library, Fund, Status. > >Test plan: >1) Add some suggestions and navigate to the suggestions page >2) Use the search bar to search for data in any of the columns mentioned above. >3) It will not filter the results based on those columns >4) Apply patch and hard refresh >5) Use the search bar again, this time it should return results > >Signed-off-by: Ludovic <ludovic.julien@inlibro.com> >Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >--- > .../prog/en/modules/suggestion/suggestion.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index c6b25551d2..3c287e1e26 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1387,7 +1387,7 @@ > }, > { > data: "suggester.category.name", >- searchable: false, >+ searchable: true, > orderable: true, > render: function (data, type, row, meta) { > return escape_str(row.suggester ? row.suggester.category.name : ''); >@@ -1403,7 +1403,7 @@ > }, > { > data: "patron_reason", >- searchable: false, >+ searchable: true, > orderable: true, > render: function (data, type, row, meta) { > return escape_str(row._strings.patron_reason.str ? row._strings.patron_reason.str : ''); >@@ -1463,7 +1463,7 @@ > }, > { > data: "library.name", >- searchable: false, >+ searchable: true, > orderable: true, > render: function (data, type, row, meta) { > return escape_str(row.library?.name ? row.library.name : ''); >@@ -1471,7 +1471,7 @@ > }, > { > data: "fund.name", >- searchable: false, >+ searchable: true, > orderable: true, > render: function (data, type, row, meta) { > return escape_str(row.fund?.name ? row.fund.name : ''); >@@ -1487,7 +1487,7 @@ > }, > { > data: "status", >- searchable: false, >+ searchable: true, > orderable: true, > render: function (data, type, row, meta) { > let node = ''; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40593
:
185536
|
186249
|
186896
|
186987