Bugzilla – Attachment 186902 Details for
Bug 23260
Anonymize (remove) patron data from items_last_borrower
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23260: (QA followup) Prevent use of cronjob when AnonymousPatron not set
Bug-23260-QA-followup-Prevent-use-of-cronjob-when-.patch (text/plain), 3.43 KB, created by
Andrew Fuerste-Henry
on 2025-09-24 20:21:04 UTC
(
hide
)
Description:
Bug 23260: (QA followup) Prevent use of cronjob when AnonymousPatron not set
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-09-24 20:21:04 UTC
Size:
3.43 KB
patch
obsolete
>From a1a1812d78889c6451c5c9bd75f718b59b8fadfc Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Wed, 24 Sep 2025 20:16:56 +0000 >Subject: [PATCH] Bug 23260: (QA followup) Prevent use of cronjob when > AnonymousPatron not set > >To test: >1 - configure StoreLastBorrower but not AnonymousPatron >2 - perl misc/cronjobs/anonymize_last_borrowers.pl -c >3 - the cron tells 'Preference 'AnonymousPatron' must be enabled to anonymize item's last borrower' >4 - put a value in AnonymousPatron >5 - repeat 2 >6 - cron runs good >--- > Koha/Patrons.pm | 7 ++++--- > misc/cronjobs/anonymize_last_borrowers.pl | 11 ++++++++--- > 2 files changed, 12 insertions(+), 6 deletions(-) > >diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm >index a3bf56530d9..3ebd17d5a43 100644 >--- a/Koha/Patrons.pm >+++ b/Koha/Patrons.pm >@@ -204,19 +204,20 @@ sub anonymize_last_borrowers { > my ( $self, $params ) = @_; > > return unless C4::Context->preference("AnonymizeLastBorrower"); >+ return unless C4::Context->preference("AnonymousPatron"); > my $days = C4::Context->preference("AnonymizeLastBorrowerDays") || 0; > my ( $year, $month, $day ) = Today(); > my ( $newyear, $newmonth, $newday ) = Add_Delta_Days( $year, $month, $day, (-1) * $days ); > my $older_than_date = dt_from_string( sprintf "%4d-%02d-%02d", $newyear, $newmonth, $newday ); > >- my $anonymous_patron = C4::Context->preference('AnonymousPatron') || undef; >+ my $anonymous_patron = C4::Context->preference('AnonymousPatron'); > > my $dtf = Koha::Database->new->schema->storage->datetime_parser; > my $rs = $self->_resultset->search( > { > created_on => { '<' => $dtf->format_datetime($older_than_date), }, >- 'items_last_borrowers.borrowernumber' => { 'not' => undef }, # Keep forever >- ( $anonymous_patron ? ( 'items_last_borrowers.borrowernumber' => { '!=' => $anonymous_patron } ) : () ), >+ 'items_last_borrowers.borrowernumber' => { 'not' => undef }, # Keep forever >+ 'items_last_borrowers.borrowernumber' => { '!=' => $anonymous_patron }, > }, > { > join => ["items_last_borrowers"], >diff --git a/misc/cronjobs/anonymize_last_borrowers.pl b/misc/cronjobs/anonymize_last_borrowers.pl >index 5e6b809c2fe..900639f309e 100755 >--- a/misc/cronjobs/anonymize_last_borrowers.pl >+++ b/misc/cronjobs/anonymize_last_borrowers.pl >@@ -40,7 +40,6 @@ Usage: $0 [-h|--help] > -v --verbose gives a little more information > -h --help prints this help message, and exits, ignoring all > other options >-Note: If the system preference 'AnonymousPatron' is not defined, NULL will be used. > USAGE > exit $_[0]; > } >@@ -57,13 +56,19 @@ if ($help) { > usage(0); > } > >-my $pref = C4::Context->preference("AnonymizeLastBorrower"); >+my $pref1 = C4::Context->preference("AnonymizeLastBorrower"); >+my $pref2 = C4::Context->preference("AnonymousPatron"); > >-if ( !$pref ) { >+if ( !$pref1 ) { > print "Preference 'AnonymizeLastBorrower' must be enabled to anonymize item's last borrower\n\n"; > usage(1); > } > >+if ( !$pref2 ) { >+ print "Preference 'AnonymousPatron' must be enabled to anonymize item's last borrower\n\n"; >+ usage(1); >+} >+ > unless ($confirm) { > print STDERR "You must use the --confirm flag to run this script.\n"; > print STDERR "Add --confirm to actually perform the anonymization.\n"; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23260
:
92863
|
92864
|
93052
|
94858
|
94859
|
95033
|
95457
|
95458
|
95459
|
95460
|
95651
|
95698
|
95699
|
95700
|
95701
|
95769
|
95770
|
95771
|
95772
|
96791
|
97841
|
97842
|
98044
|
98053
|
98054
|
98064
|
98282
|
98349
|
98352
|
112734
|
112735
|
112736
|
112737
|
112738
|
112739
|
112740
|
112741
|
112742
|
112743
|
117974
|
117975
|
117976
|
117977
|
117978
|
117979
|
117980
|
117981
|
117982
|
117983
|
120522
|
120523
|
120524
|
120525
|
120526
|
120527
|
120528
|
120529
|
120530
|
120531
|
122963
|
122964
|
122965
|
122966
|
122967
|
122968
|
122969
|
122970
|
122971
|
122972
|
145175
|
145176
|
145177
|
145178
|
145179
|
145180
|
145181
|
145182
|
145183
|
145184
|
157106
|
157107
|
157108
|
157109
|
157110
|
157111
|
157112
|
157113
|
157114
|
157115
|
157116
|
159291
|
159292
|
159293
|
159294
|
159298
|
159299
|
159300
|
159301
|
164129
|
164130
|
164131
|
164132
|
164133
|
182000
|
182001
|
182002
|
182003
|
182004
|
182005
|
182006
|
182007
|
182927
|
182930
|
186835
|
186836
|
186837
|
186838
|
186839
|
186840
|
186843
| 186902 |
186942
|
186943
|
186948