Bugzilla – Attachment 187113 Details for
Bug 35700
Holds reminder cronjob --triggered switch does not work as intended if the day to send notice hits concurrent holidays
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35700: Holds reminder cronjob --triggered switch does not work as intended if the day to send notice hits concurrent holidays
Bug-35700-Holds-reminder-cronjob---triggered-switc.patch (text/plain), 2.33 KB, created by
Lisette Scheer
on 2025-09-30 16:26:49 UTC
(
hide
)
Description:
Bug 35700: Holds reminder cronjob --triggered switch does not work as intended if the day to send notice hits concurrent holidays
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2025-09-30 16:26:49 UTC
Size:
2.33 KB
patch
obsolete
>From 30cf71a82e837afe06eb722c46934ed36b4c8cd7 Mon Sep 17 00:00:00 2001 >From: Lisette Scheer <lisette@bywatersolutions.com> >Date: Tue, 30 Sep 2025 16:25:56 +0000 >Subject: [PATCH] Bug 35700: Holds reminder cronjob --triggered switch does not > work as intended if the day to send notice hits concurrent holidays > >If the holds reminder cronjob would send a reminder on a holiday,when holidays are taken into account, it also will send it on the subsequent holidays and the first open day. >This bugfix adds a check to the cron when --holidays is set to skip sending the notices for that library if today is a holiday. > >To Test: >Before applying: >1. Create a hold for a patron (I used patron 23529000035676 and 39999000000252) >2. Ensure your patron has an email address set and the hold reminder email selected. >3. Set the hold to waiting by checking it and confirming the hold. >4. In Tools->Calendar add a holiday to yesterday and a seperate holiday to today. >5. On the command line (the date should be set to 5 days ago for my commands to work and any dates adjusted accordingly) >koha-mysql kohadev >update reserves set waitingdate="2025-09-25" >exit >perl misc/cronjobs/holds/holds_reminder.pl -days 3 -t -v -holidays --date 2025-09-29 >6. Observe that 1 notice would have sent to your patron >7. On the command line >perl misc/cronjobs/holds/holds_reminder.pl -days 3 -t -v -holidays >8. Observe that 1 notice would have sent to your patron >9. On the command line >perl misc/cronjobs/holds/holds_reminder.pl -days 3 -t -v -holidays --date 2025-10-01 >10. Observe that 1 notice would have sent to your patron > >11. Apply patches >12. Repeat the last command from step 5 and step 7 >13. Observe that no notice should be sent for your patron >14. Repeat step 7 >15. Observe that a notice should be sent for your patron. >16. Run >perl misc/cronjobs/holds/holds_reminder.pl -days 5 -t -v >17. Confirm the notice should be sent for your patron >18. Sign off >--- > misc/cronjobs/holds/holds_reminder.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/misc/cronjobs/holds/holds_reminder.pl b/misc/cronjobs/holds/holds_reminder.pl >index f661bb1da44..5d19d3352f4 100755 >--- a/misc/cronjobs/holds/holds_reminder.pl >+++ b/misc/cronjobs/holds/holds_reminder.pl >@@ -31,7 +31,6 @@ use Koha::Libraries; > use Koha::Notice::Templates; > use Koha::Patrons; > use Koha::Script -cron; >-use Data::Dumper; > > =head1 NAME > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35700
:
187112
|
187113
|
187114
|
187115
|
187426
|
187482
|
187505