Bugzilla – Attachment 187156 Details for
Bug 38489
EDI should be updated to use the new FTP/SFTP Servers management page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38489: Update EDI tests to use new file transport system
Bug-38489-Update-EDI-tests-to-use-new-file-transpo.patch (text/plain), 8.80 KB, created by
Martin Renvoize (ashimema)
on 2025-10-01 07:03:52 UTC
(
hide
)
Description:
Bug 38489: Update EDI tests to use new file transport system
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-10-01 07:03:52 UTC
Size:
8.80 KB
patch
obsolete
>From e42393f54e43146dde1759580a18e5e42700d10c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Tue, 23 Sep 2025 20:01:40 +0100 >Subject: [PATCH] Bug 38489: Update EDI tests to use new file transport system > >The EDI test was still creating vendor_edi_accounts with transport='FILE' >which no longer works after the migration to the file_transports system. > >Updated all test account creation to: >- Create file_transports records with transport='local' >- Link EDI accounts via file_transport_id instead of direct transport field >- Set appropriate download/upload directories for local testing > >All EDI tests now pass with the new transport architecture. > >Sponsored-by: ByWater Solutions >Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> >--- > t/db_dependent/Koha/EDI.t | 129 +++++++++++++++++++----- > t/db_dependent/Koha/Edifact/Transport.t | 2 +- > 2 files changed, 106 insertions(+), 25 deletions(-) > >diff --git a/t/db_dependent/Koha/EDI.t b/t/db_dependent/Koha/EDI.t >index 01d295c71d2..b3f96180e45 100755 >--- a/t/db_dependent/Koha/EDI.t >+++ b/t/db_dependent/Koha/EDI.t >@@ -59,16 +59,29 @@ subtest 'process_quote' => sub { > > $schema->storage->txn_begin; > >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Local Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'test vendor', >- transport => 'FILE', >- plugin => '', >- san => $test_san, >- orders_enabled => 1, >- auto_orders => 0, >+ description => 'test vendor', >+ file_transport_id => $file_transport->{file_transport_id}, >+ plugin => '', >+ san => $test_san, >+ orders_enabled => 1, >+ auto_orders => 0, > } > } > ); >@@ -228,16 +241,30 @@ subtest 'process_quote' => sub { > plan tests => 7; > > $schema->storage->txn_begin; >+ >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Auto Order Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'auto order vendor', >- transport => 'FILE', >- plugin => '', >- san => $test_san, >- orders_enabled => 1, >- auto_orders => 1, >+ description => 'auto order vendor', >+ file_transport_id => $file_transport->{file_transport_id}, >+ plugin => '', >+ san => $test_san, >+ orders_enabled => 1, >+ auto_orders => 1, > } > } > ); >@@ -315,14 +342,27 @@ subtest 'process_quote' => sub { > > $schema->storage->txn_begin; > >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Multi-item Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > # Create vendor EDI account > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'multi-item vendor', >- transport => 'FILE', >- plugin => '', >+ description => 'multi-item vendor', >+ file_transport_id => $file_transport->{file_transport_id}, >+ plugin => '', > } > } > ); >@@ -475,12 +515,25 @@ subtest 'process_quote' => sub { > > $schema->storage->txn_begin; > >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Error Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'error test vendor', >- transport => 'FILE', >+ description => 'error test vendor', >+ file_transport_id => $file_transport->{file_transport_id}, > } > } > ); >@@ -582,12 +635,25 @@ subtest 'process_quote' => sub { > > $schema->storage->txn_begin; > >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Multiple Message Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'error test vendor', >- transport => 'FILE', >+ description => 'error test vendor', >+ file_transport_id => $file_transport->{file_transport_id}, > } > } > ); >@@ -646,15 +712,31 @@ subtest 'process_invoice' => sub { > > $schema->storage->txn_begin; > >+ # Get dirname for transport >+ my $dirname = ( $Bin =~ /^(.*\/t\/)/ ? $1 . 'edi_testfiles/' : q{} ); >+ >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Invoice Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > # Add test EDI matching ean of test invoice file and ensure no plugins so we trigger core functions > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'test vendor', >- transport => 'FILE', >- plugin => '', >- san => '5013546027173' >+ description => 'test vendor', >+ file_transport_id => $file_transport->{file_transport_id}, >+ plugin => '', >+ san => '5013546027173' > } > } > ); >@@ -694,7 +776,6 @@ subtest 'process_invoice' => sub { > my $ordernumber2 = $order2->ordernumber; > > # Add test invoice file to the database for testing >- my $dirname = ( $Bin =~ /^(.*\/t\/)/ ? $1 . 'edi_testfiles/' : q{} ); > my $filename = 'INVOICE.CEI'; > ok( -e $dirname . $filename, 'File INVOICE.CEI found' ); > >diff --git a/t/db_dependent/Koha/Edifact/Transport.t b/t/db_dependent/Koha/Edifact/Transport.t >index 3e4efbb45ac..e676e62d067 100755 >--- a/t/db_dependent/Koha/Edifact/Transport.t >+++ b/t/db_dependent/Koha/Edifact/Transport.t >@@ -21,7 +21,7 @@ my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'test vendor', transport => 'FILE', >+ description => 'test vendor', > } > } > ); >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38489
:
175204
|
175205
|
175206
|
175207
|
176118
|
176119
|
176161
|
185324
|
186819
|
186820
|
186845
|
186846
|
186847
|
186848
|
186849
|
186850
|
186851
|
186852
|
186854
|
187080
|
187081
|
187082
|
187083
|
187084
|
187085
|
187086
|
187087
|
187088
|
187089
|
187108
|
187147
|
187148
|
187149
|
187150
|
187151
|
187152
|
187153
|
187154
|
187155
|
187156
|
187157
|
187158
|
187159
|
187270
|
187271
|
187272
|
187273
|
187274
|
187275
|
187276
|
187277
|
187278
|
187279
|
187280
|
187281
|
187283
|
187284
|
187285
|
187286
|
187287
|
187288
|
187289
|
187290
|
187291
|
187292
|
187293
|
187294