Attachment 18735 Details for Bug 10354 – [ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl

[patch] [ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl

Bug-10354-Remove-erroneous-call-to-haspermission-i.patch (text/plain), 1.14 KB, created by Jonathan Druart on 2013-06-07 12:37:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-06-07 12:37:09 UTC

Size: 1.14 KB

patch

obsolete

>From d29886a36999a52a2defa137d5c8afe5496c40d4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Fri, 7 Jun 2013 14:36:17 +0200
>Subject: [PATCH] Bug 10354: Remove erroneous call to haspermission in
> basket.pl
>
>---
> acqui/basket.pl |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/acqui/basket.pl b/acqui/basket.pl
>index 7eff6e4..10e7568 100755
>--- a/acqui/basket.pl
>+++ b/acqui/basket.pl
>@@ -207,8 +207,8 @@ if ( $op eq 'delete_confirm' ) {
>     }
> #if the basket is closed,and the user has the permission to edit basketgroups, display a list of basketgroups
>     my ($basketgroup, $basketgroups);
>-    my $member = GetMember(borrowernumber => $loggedinuser);
>-    if ($basket->{closedate} && haspermission({ acquisition => 'group_manage'} )) {
>+    my $uid = GetMember(borrowernumber => $loggedinuser)->{userid};
>+    if ($basket->{closedate} && haspermission($uid, { acquisition => 'group_manage'} )) {
>         $basketgroups = GetBasketgroups($basket->{booksellerid});
>         for my $bg ( @{$basketgroups} ) {
>             if ($basket->{basketgroupid} && $basket->{basketgroupid} == $bg->{id}){
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10354: 18544 | 18593 | 18732 | 18735