Bugzilla – Attachment 187379 Details for
Bug 40943
Store session_id in userenv
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40943: Store session_id in userenv
Bug-40943-Store-sessionid-in-userenv.patch (text/plain), 3.75 KB, created by
Jonathan Druart
on 2025-10-03 11:27:24 UTC
(
hide
)
Description:
Bug 40943: Store session_id in userenv
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-03 11:27:24 UTC
Size:
3.75 KB
patch
obsolete
>From 229ba3a02a92f170c000b40e43a2659b42fe3839 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 24 Sep 2024 15:22:34 +0200 >Subject: [PATCH] Bug 40943: Store session_id in userenv > >--- > C4/Auth.pm | 36 ++++++------------------------------ > 1 file changed, 6 insertions(+), 30 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 20242735e1a..8206c9f98c5 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1351,17 +1351,8 @@ sub checkauth { > $session->param( 'register_name', $register_name ); > $session->param( 'sco_user', $is_sco_user ); > } >- $session->param( 'cas_ticket', $cas_ticket ) if $cas_ticket; >- C4::Context->set_userenv( >- $session->param('number'), $session->param('id'), >- $session->param('cardnumber'), $session->param('firstname'), >- $session->param('surname'), $session->param('branch'), >- $session->param('branchname'), $session->param('flags'), >- $session->param('emailaddress'), $session->param('shibboleth'), >- $session->param('desk_id'), $session->param('desk_name'), >- $session->param('register_id'), $session->param('register_name') >- ); >- >+ $session->param('cas_ticket', $cas_ticket) if $cas_ticket; >+ C4::Context->set_userenv_from_session($session); > } > > # $return: 0 = invalid user >@@ -1829,16 +1820,8 @@ sub check_api_auth { > $session->param( 'lasttime', time() ); > $session->param( 'interface', 'api' ); > } >- $session->param( 'cas_ticket', $cas_ticket ); >- C4::Context->set_userenv( >- $session->param('number'), $session->param('id'), >- $session->param('cardnumber'), $session->param('firstname'), >- $session->param('surname'), $session->param('branch'), >- $session->param('branchname'), $session->param('flags'), >- $session->param('emailaddress'), $session->param('shibboleth'), >- $session->param('desk_id'), $session->param('desk_name'), >- $session->param('register_id'), $session->param('register_name') >- ); >+ $session->param( 'cas_ticket', $cas_ticket); >+ C4::Context->set_userenv_from_session($session); > return ( "ok", $cookie, $sessionID ); > } else { > return ( "failed", undef, undef ); >@@ -1958,15 +1941,8 @@ sub check_cookie_auth { > # No need to override the interface, most often set by get_template_and_user > C4::Context->interface( $session->param('interface') ); > } >- C4::Context->set_userenv( >- $session->param('number'), $session->param('id') // '', >- $session->param('cardnumber'), $session->param('firstname'), >- $session->param('surname'), $session->param('branch'), >- $session->param('branchname'), $session->param('flags'), >- $session->param('emailaddress'), $session->param('shibboleth'), >- $session->param('desk_id'), $session->param('desk_name'), >- $session->param('register_id'), $session->param('register_name') >- ); >+ >+ C4::Context->set_userenv_from_session($session); > if ( C4::Context->preference('TwoFactorAuthentication') ne 'disabled' ) { > return ( "additional-auth-needed", $session ) > if $session->param('waiting-for-2FA'); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40943
:
187379
|
187380
|
187720
|
187721
|
187722