Bugzilla – Attachment 187436 Details for
Bug 40950
Don't forbid 'falsy' in codespell
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40950: Add 'falsy' programming idiom to codespell dictionary
Bug-40950-Add-falsy-programming-idiom-to-codespell.patch (text/plain), 2.20 KB, created by
Jonathan Druart
on 2025-10-06 07:21:50 UTC
(
hide
)
Description:
Bug 40950: Add 'falsy' programming idiom to codespell dictionary
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-06 07:21:50 UTC
Size:
2.20 KB
patch
obsolete
>From 31728450373eb222458a2871439fd95c2b2f6653 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= <tomascohen@theke.io> >Date: Fri, 3 Oct 2025 12:09:45 -0300 >Subject: [PATCH] Bug 40950: Add 'falsy' programming idiom to codespell > dictionary >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The term 'falsy' is a standard JavaScript idiom referring to values >that evaluate to false in boolean contexts (false, 0, '', null, >undefined, NaN). This is widely used in modern JavaScript and is >part of the official ECMAScript specification terminology. I also >believe it is relevant for Perl. > >Codespell currently flags 'falsy' as a misspelling, but this is >incorrect as it's legitimate technical terminology used throughout >our JavaScript codebase and documentation. > >Changes: >- Add 'falsy' to codespell exceptions/dictionary >- Allows proper use of JavaScript terminology in code and comments > >Test plan: >1. Apply patch >2. Run codespell on files containing 'falsy' >=> SUCCESS: No longer flagged as misspelling >3. Verify 'falsy' usage in JavaScript context works correctly >4. Sign off :-D > >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .codespell-ignore | 1 + > t/cypress/component/ShowElement_spec.ts | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/.codespell-ignore b/.codespell-ignore >index 7c249c70811..9bc4879d1d1 100644 >--- a/.codespell-ignore >+++ b/.codespell-ignore >@@ -17,3 +17,4 @@ sav > theses > rouge > connexion >+falsy >diff --git a/t/cypress/component/ShowElement_spec.ts b/t/cypress/component/ShowElement_spec.ts >index 95c8da941b7..2cf9ca4720e 100644 >--- a/t/cypress/component/ShowElement_spec.ts >+++ b/t/cypress/component/ShowElement_spec.ts >@@ -36,7 +36,7 @@ describe("ShowElement", () => { > cy.get("label").contains("Name"); > cy.get("span").contains(resource.name); > }); >- it("should hide that property if the hidden attribute is set and false", () => { >+ it("should hide that property if the hidden attribute is set and falsy", () => { > cy.mount(ShowElement, { > props: { > resource, >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40950
:
187408
| 187436