Bugzilla – Attachment 187447 Details for
Bug 40292
SQL syntax error when upgrading to 25.05 on MariaDB 10.3, RENAME COLUMN unsupported
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40292: (QA follow-up) Tidy db_revs/241200018.pl, atomicupdate/bug_40292.pl
Bug-40292-QA-follow-up-Tidy-dbrevs241200018pl-atom.patch (text/plain), 2.15 KB, created by
Paul Derscheid
on 2025-10-06 08:39:15 UTC
(
hide
)
Description:
Bug 40292: (QA follow-up) Tidy db_revs/241200018.pl, atomicupdate/bug_40292.pl
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2025-10-06 08:39:15 UTC
Size:
2.15 KB
patch
obsolete
>From ce64d3a2c1ea490f0ebeed0053045ba5c76d24e2 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Mon, 6 Oct 2025 10:37:27 +0200 >Subject: [PATCH] Bug 40292: (QA follow-up) Tidy db_revs/241200018.pl, > atomicupdate/bug_40292.pl > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > installer/data/mysql/atomicupdate/bug_40292.pl | 2 +- > installer/data/mysql/db_revs/241200018.pl | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_40292.pl b/installer/data/mysql/atomicupdate/bug_40292.pl >index e6a7e54bd36..9265c5adb35 100755 >--- a/installer/data/mysql/atomicupdate/bug_40292.pl >+++ b/installer/data/mysql/atomicupdate/bug_40292.pl >@@ -8,7 +8,7 @@ return { > my ($args) = @_; > my ( $dbh, $out ) = @$args{qw(dbh out)}; > >- if ( column_exists('additional_field_values', 'new_record_id') ) { >+ if ( column_exists( 'additional_field_values', 'new_record_id' ) ) { > $dbh->do( > q{ ALTER TABLE additional_field_values CHANGE COLUMN new_record_id record_id VARCHAR(11) NOT NULL DEFAULT '' COMMENT 'record_id'; } > ); >diff --git a/installer/data/mysql/db_revs/241200018.pl b/installer/data/mysql/db_revs/241200018.pl >index 1ef9917fa39..318e00714d0 100755 >--- a/installer/data/mysql/db_revs/241200018.pl >+++ b/installer/data/mysql/db_revs/241200018.pl >@@ -12,8 +12,9 @@ return { > $sth->execute(); > my $column_info = $sth->fetchrow_hashref(); > >- if ( column_exists('additional_field_values', 'new_record_id') ) { >- die "The database is an inconsistent state, a previous upgrade went wrong. Please try a new upgrade from a previous backup and using a newest version of Koha"; >+ if ( column_exists( 'additional_field_values', 'new_record_id' ) ) { >+ die >+ "The database is an inconsistent state, a previous upgrade went wrong. Please try a new upgrade from a previous backup and using a newest version of Koha"; > } elsif ( $column_info && $column_info->{Type} eq 'int(11)' ) { > > # Only run the migration if record_id is still an integer type >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40292
:
183706
|
183747
|
183748
|
183749
|
183750
|
183754
|
183775
|
183777
|
183778
|
183779
|
187428
|
187438
|
187439
|
187440
|
187441
|
187442
|
187443
|
187444
|
187445
|
187446
|
187447
|
188061
|
188758
|
188759
|
188760
|
188761
|
188762
|
188763
|
188764
|
188765