Bugzilla – Attachment 187472 Details for
Bug 40699
Preferred name not displayed for instructors in course reserves in staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40699: Correctly format patron everywhere in course reserves
Bug-40699-Correctly-format-patron-everywhere-in-co.patch (text/plain), 3.42 KB, created by
Jonathan Druart
on 2025-10-06 12:32:22 UTC
(
hide
)
Description:
Bug 40699: Correctly format patron everywhere in course reserves
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-06 12:32:22 UTC
Size:
3.42 KB
patch
obsolete
>From 17572d819d270ea1d3fbd4fc56e8c89ec601b8b0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 6 Oct 2025 14:31:19 +0200 >Subject: [PATCH] Bug 40699: Correctly format patron everywhere in course > reserves > >--- > .../prog/en/modules/course_reserves/course-reserves.tt | 2 +- > .../prog/en/modules/course_reserves/course.tt | 7 ++++--- > 2 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt >index 24e8ba6a401..a13e0f73ca5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt >@@ -71,7 +71,7 @@ > <td>[% AuthorisedValues.GetByCode( 'TERM' c.term ) | html %]</td> > <td> > [% FOREACH i IN c.instructors %] >- <div class="instructor"><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% i.borrowernumber | uri %]">[% i.firstname | html %] [% i.surname | html %]</a></div> >+ <div class="instructor"><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% i.borrowernumber | uri %]">[% INCLUDE 'patron-title.inc' patron=i no_cardnumber=1 %]</a></div> > [% END %] > </td> > <td>[% c.staff_note | html %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt >index d61e2d08c73..d0ae81c4026 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt >@@ -131,8 +131,8 @@ > <div id="course_instructors"> > <div id="instructors"> > [% FOREACH i IN instructors %] >- <div class="instructor_line" id="borrower_[% i.borrowernumber | html %]" >- >[% i.surname | html %], [% i.firstname | html %] ( <a href="#" class="removeInstructor"><i class="fa fa-trash-can"></i> Remove </a> ) >+ <div class="instructor_line" id="borrower_[% i.borrowernumber | html %]"> >+ [% INCLUDE 'patron-title.inc' patron=i no_cardnumber=1 %] (<a href="#" class="removeInstructor"><i class="fa fa-trash-can"></i> Remove </a>) > <input type="hidden" name="instructors" value="[% i.borrowernumber | html %]" /> > </div> > [% END %] >@@ -195,11 +195,12 @@ > > [% IF ( departments ) %] > [% MACRO jsinclude BLOCK %] >+ [% INCLUDE 'js-patron-format.inc' %] > <script> > $(document).ready(function () { > patron_autocomplete($("#find_instructor"), { > "on-select-callback": function (event, ui) { >- AddInstructor(ui.item.surname + ", " + ui.item.firstname, ui.item.patron_id); >+ AddInstructor($patron_to_html(ui.item, { display_cardnumber: false }), ui.item.patron_id); > return false; > }, > }); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40699
:
185745
|
186233
| 187472