Bugzilla – Attachment 187480 Details for
Bug 40939
Cardnumber not found when performing batch actions from report results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40939: Fix batch actions from report results
Bug-40939-Fix-batch-actions-from-report-results.patch (text/plain), 2.88 KB, created by
Brendan Lawlor
on 2025-10-06 14:45:31 UTC
(
hide
)
Description:
Bug 40939: Fix batch actions from report results
Filename:
MIME Type:
Creator:
Brendan Lawlor
Created:
2025-10-06 14:45:31 UTC
Size:
2.88 KB
patch
obsolete
>From d2b522d3ff2a250e452aade6d319e5707b00ceb4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 6 Oct 2025 09:31:47 +0200 >Subject: [PATCH] Bug 40939: Fix batch actions from report results > >Batch patron operations are broken when using cardnumbers > >From > commit d659526b5ae3363de6dc7691a782a45aaf781a46 > Bug 38664: Tidy the whole codebase > >- [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] >-[%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] >+ [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] >+ [%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] > >The auto tidy added the whitespaces back > >This patch suggests to use TT to add the new lines. > >+ [%- cells.cell | html -%][% "\n" | $raw %][%# We want 1 item per line, without whitespace %] > >Test plan: >- save and run "SELECT cardnumber FROM borrowers" >- use the Batch Operations button to send all visible cardnumbers to batch patron modification >- see that all of your cardnumbers have been found > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index d8be142676..200cffb54e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1085,9 +1085,9 @@ > [%- FOREACH result IN results %] > [%- FOREACH cells IN result.cells %] > [%- place = loop.index %] >- [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] >- [%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] >- [%- END %] >+ [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type -%] >+ [%- cells.cell | html -%][% "\n" | $raw %][%# We want 1 item per line, without whitespace %] >+ [%- END -%] > [%- END %] > [%- END -%] > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40939
:
187437
| 187480