Bugzilla – Attachment 187482 Details for
Bug 35700
Holds reminder cronjob --triggered switch does not work as intended if the day to send notice hits concurrent holidays
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35700: (QA follow-up) fix POD and $today
Bug-35700-QA-follow-up-fix-POD-and-today.patch (text/plain), 1.95 KB, created by
Lisette Scheer
on 2025-10-06 16:17:37 UTC
(
hide
)
Description:
Bug 35700: (QA follow-up) fix POD and $today
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2025-10-06 16:17:37 UTC
Size:
1.95 KB
patch
obsolete
>From ad997a570bf5d3d1c4759caf9a9259f4f9ea5ca5 Mon Sep 17 00:00:00 2001 >From: Lisette Scheer <lisette@bywatersolutions.com> >Date: Mon, 6 Oct 2025 15:26:10 +0000 >Subject: [PATCH] Bug 35700: (QA follow-up) fix POD and $today > >This patch replaces the inncorrectly removed POD note and replaces $today with the more correct $date_to_run for checking if we should be skipping sending the message on the day. >--- > misc/cronjobs/holds/holds_reminder.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/misc/cronjobs/holds/holds_reminder.pl b/misc/cronjobs/holds/holds_reminder.pl >index c5c87278ff6..33ccfb37c8d 100755 >--- a/misc/cronjobs/holds/holds_reminder.pl >+++ b/misc/cronjobs/holds/holds_reminder.pl >@@ -42,6 +42,7 @@ holds_reminder.pl > -lettercode <notice to send> > [ -c ][ -v ][ -library <branchcode> ][ -library <branchcode> ... ] > [ -days <number of days> ][ -mtt <transport type> ... ][ -holidays ] >+ [ -date <YYYY-MM-DD> ] > > Options: > -help brief help message >@@ -188,7 +189,7 @@ GetOptions( > 'library=s' => \@branchcodes, > 'date=s' => \$date_input, > 'holidays' => \$use_calendar, >- 'mtt=s' => \@mtts, >+ 'mtt=s' => \@mtts > ); > pod2usage(1) if $help; > pod2usage( -verbose => 2 ) if $man; >@@ -241,11 +242,10 @@ foreach my $branchcode (@branchcodes) { #BEGIN BRANCH LOOP > # If respecting calendar get the correct waiting since date > my $waiting_date; > if ($use_calendar) { >- my $today = $date_to_run; > my $calendar = Koha::Calendar->new( branchcode => $branchcode, days_mode => 'Calendar' ); > > #if today is a holiday skip sending the message >- next if $calendar->is_holiday($today); >+ next if $calendar->is_holiday($date_to_run); > { > my $duration = DateTime::Duration->new( days => -$days ); > $waiting_date = $calendar->addDays( $date_to_run, $duration ); #Add negative of days >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35700
:
187112
|
187113
|
187114
|
187115
|
187426
|
187482
|
187505