Bugzilla – Attachment 187657 Details for
Bug 39514
If one basket has uncertain prices, all basket are displayed in red
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39514: Only mark the affected rows as problematic
Bug-39514-Only-mark-the-affected-rows-as-problemat.patch (text/plain), 2.43 KB, created by
Nick Clemens (kidclamp)
on 2025-10-09 13:00:53 UTC
(
hide
)
Description:
Bug 39514: Only mark the affected rows as problematic
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-10-09 13:00:53 UTC
Size:
2.43 KB
patch
obsolete
>From af685c86e0a6a832f44e92b0eb23cf5741fbfb42 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 9 Oct 2025 12:58:36 +0000 >Subject: [PATCH] Bug 39514: Only mark the affected rows as problematic > >Before this patch we were setting a variable and nebver unsetting it > >Now we can add the conditional directly to the row, so don't need a variable > >To test: >1. Go to Acquisitions >2. Click 'Search' in the vendor search >3. Click 'Add to basket' next to 'My basket' >4. Click 'From a new (empty) record' >5. Fill out the form > - Title: enter a title > - Koha item type: choose an item type > 5.1. Click 'Add item' > - Fund: choose a fund > - Uncertain price: check >6. Click 'Save' >7. Go back to Acquisitions >8. Click 'Search' in the vendor search >9. Click 'New' > 'Basket' >10. Enter a basket name >11. Click 'Save' >12. Go back to Acquistions >13. Click 'Search' in the vendor search >--> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices >14. Click 'Add to basket' >--> Notice everything is in bold and some in red >15. Apply patch, reload >16. Only affected basket is in red >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt >index 4e507b027ab..5b47155eab4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt >@@ -114,10 +114,7 @@ > </thead> > <tbody> > [% FOREACH basket IN supplier.loop_basket %] >- [% IF ( basket.uncertainprices ) %] >- [% SET tr_class="problem" %] >- [% END %] >- <tr class="[% tr_class | html %]"> >+ <tr [% IF ( basket.uncertainprices ) %]class="problem"[% END %]> > <td>[% basket.basketno | html %]</td> > <td><a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basket.basketno | uri %]">[% basket.basketname | html %]</a></td> > <td data-order="[% basket.total_items | html %]"> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39514
:
187657
|
187662