Bugzilla – Attachment 187666 Details for
Bug 40918
Invoice Adjustment Reason always "No reason" even if report shows a saved reason
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40918: Fix invoice adjustement reason selection
Bug-40918-Fix-invoice-adjustement-reason-selection.patch (text/plain), 2.54 KB, created by
Martin Renvoize (ashimema)
on 2025-10-09 14:28:59 UTC
(
hide
)
Description:
Bug 40918: Fix invoice adjustement reason selection
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-10-09 14:28:59 UTC
Size:
2.54 KB
patch
obsolete
>From 8ff081eab993d04705d9857729444d13ace4cd64 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 6 Oct 2025 12:38:39 +0200 >Subject: [PATCH] Bug 40918: Fix invoice adjustement reason selection > >From > commit 46f7158f44ced21571dc9deef9ca240fc34a8e6b > Bug 38714: acqui/invoice.tt > >Debugging stuff left, sorry! > >Test plan: >1. Go to Acquisition. >2. Create a vendor. >3. Click "Receive Shipment" >4. Enter an invoice number and save. >5. Go to Administration->Authorized Values->Add A Category >6. Name it ADJ_REASON >7. Put in 2 options >8. Go to invoices in Aqusition >9. Add an adjustment (enter an amount and select a reason, then save) >10. The reason is set to "no reason" >11. Go to reports >12. new sql report >select * from aqinvoice_adjustments >13. Run the report and see your reason is saved. >14. go back to the invoice and click save adjustments >15. Run the report and see your reason is saved. > >Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >index 91ef1acade2..bf7b5fa4e6a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >@@ -190,10 +190,7 @@ > <select id="reason_[% adjustment.adjustment_id | html %]" name="reason"> > <option value="">No reason</option> > [% FOREACH reason IN reasons %] >- [% IF ( adjustment.reason == reason.authorised_value ) %] >- [% SET selected_attr = 'selected="selected"' %] >- [% END %] >- <option [% IF foo %]selected="selected"[% END %] value="[% reason.authorised_value | html %]"> [% reason.lib | html %] </option> >+ <option [% IF adjustment.reason == reason.authorised_value %]selected="selected"[% END %] value="[% reason.authorised_value | html %]"> [% reason.lib | html %] </option> > [% END %] > </select> > [% ELSE %] >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40918
:
187458
|
187502
| 187666