Bugzilla – Attachment 187687 Details for
Bug 40866
Corrections to override logging
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40866: Remove unused $message variable from circulation
Bug-40866-Remove-unused-message-variable-from-circ.patch (text/plain), 2.27 KB, created by
Paul Derscheid
on 2025-10-09 15:36:43 UTC
(
hide
)
Description:
Bug 40866: Remove unused $message variable from circulation
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2025-10-09 15:36:43 UTC
Size:
2.27 KB
patch
obsolete
>From 8608184b350635eeeae361eb742d3998383c6df7 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Wed, 8 Oct 2025 17:49:23 +0100 >Subject: [PATCH] Bug 40866: Remove unused $message variable from circulation > >The $message variable was declared in circ/circulation.pl but never >actually set, making the "No patron matched" template block unreachable. > >This is a remnant from old code that was incompletely cleaned when that >functionality was changed/removed. > >This patch removes the unused variable, template parameter, and the >unreachable template block. > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > circ/circulation.pl | 3 --- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 5 ----- > 2 files changed, 8 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 01209d5eef0..13a4aff0b4e 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -326,8 +326,6 @@ if ($patron) { > # STEP 3 : ISSUING > # > # >-my $message; >- > if ( @$barcodes && $op eq 'cud-checkout' ) { > my $checkout_infos; > for my $barcode (@$barcodes) { >@@ -784,7 +782,6 @@ $template->param( > stickyduedate => $stickyduedate, > duedatespec => $duedatespec, > restoreduedatespec => $restoreduedatespec, >- message => $message, > totaldue => sprintf( '%.2f', $balance ), # FIXME not used in template? > inprocess => $inprocess, > $view => 1, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 77007878821..92e438c86e2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -787,11 +787,6 @@ > <p>Item checked out</p> > [% END %] > >- [% IF ( message ) %] >- [% INCLUDE 'patron-toolbar.inc' %] >- <h4>No patron matched <span class="ex">[% message | html %]</span></h4> >- [% END %] >- > <!-- BARCODE ENTRY --> > > [% IF patron %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40866
:
186985
|
186986
|
187063
|
187116
|
187627
|
187628
|
187629
|
187630
|
187631
|
187632
|
187633
|
187675
|
187676
|
187677
|
187678
|
187679
|
187680
|
187681
|
187682
|
187683
|
187684
|
187685
|
187686
| 187687 |
187688
|
187689
|
187690
|
187691
|
187692
|
187693
|
187694
|
187707
|
187725