Bugzilla – Attachment 187690 Details for
Bug 40866
Corrections to override logging
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40866: Remove original Bug 9762 implementation remnants (Part 3 - Returns)
Bug-40866-Remove-original-Bug-9762-implementation-.patch (text/plain), 2.79 KB, created by
Paul Derscheid
on 2025-10-09 15:36:57 UTC
(
hide
)
Description:
Bug 40866: Remove original Bug 9762 implementation remnants (Part 3 - Returns)
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2025-10-09 15:36:57 UTC
Size:
2.79 KB
patch
obsolete
>From f76ac2af53fb6e817eb9f578e62a713caaae8b51 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Thu, 9 Oct 2025 07:31:43 +0100 >Subject: [PATCH] Bug 40866: Remove original Bug 9762 implementation remnants > (Part 3 - Returns) > >This patch removes the duplicate logging code from circ/returns.pl that >was part of the original Bug 9762 implementation. > >The original implementation added a separate logaction() call when >ignoring holds on return. This code created a custom JSON log entry >with the message "return an element that is reserved". > >However, this logging appears to have been orphaned - there is no >corresponding Alternative implementation for return override logging >in the current codebase. The code was creating log entries but they >were not properly integrated with any override confirmation workflow. > >Changes: > >circ/returns.pl: >- Removed entire else block that created custom override log entries >- Removed unused variables: $message, @message, $user, $branchcode, $barcode >- Removed C4::Log qw(logaction) import as it's no longer needed > >This eliminates the orphaned logging code and ensures returns.pl only >uses standard Koha logging mechanisms. > >Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > circ/returns.pl | 27 --------------------------- > 1 file changed, 27 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index e3453a3ed54..35c3367ea4b 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -42,7 +42,6 @@ use C4::Members; > use C4::Output qw( output_html_with_http_headers ); > use C4::Reserves qw( ModReserve ModReserveAffect CheckReserves ); > use C4::RotatingCollections; >-use C4::Log qw( logaction ); > use Koha::AuthorisedValues; > use Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue; > use Koha::BiblioFrameworks; >@@ -160,32 +159,6 @@ if ( $query->param('reserve_id') && $op eq 'cud-affect_reserve' ) { > $transfer->transit; > } > } >-} else { >- my $message = "return an element that is reserved"; >- my @message = ("return an element that is reserved"); >- my $user = C4::Context->userenv->{number}; >- my $branchcode = C4::Context->userenv->{branch}; >- my $barcode = $query->param('barcode'); >- >- my $infos = ( >- { >- message => \@message, >- >- #'card number' => $cardnumber, >- barcode => $barcode, >- manager_id => $user, >- branchcode => $branchcode, >- } >- ); >- >- my $json_infos = JSON->new->utf8->pretty->encode($infos); >- $json_infos =~ s/"/'/g; >- >- logaction( >- "CIRCULATION", "RETURN", >- $session, >- $json_infos, >- ) if C4::Context->preference("ReturnLog"); > } > > if ( $query->param('recall_id') && $op eq 'cud-affect_recall' ) { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40866
:
186985
|
186986
|
187063
|
187116
|
187627
|
187628
|
187629
|
187630
|
187631
|
187632
|
187633
|
187675
|
187676
|
187677
|
187678
|
187679
|
187680
|
187681
|
187682
|
187683
|
187684
|
187685
|
187686
|
187687
|
187688
|
187689
| 187690 |
187691
|
187692
|
187693
|
187694
|
187707
|
187725