Bugzilla – Attachment 187711 Details for
Bug 40982
Basket: Orders table — "Modify" and "Cancel order" columns missing or displayed incorrectly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40982: (bug 40753 follow-up) Adjust conditions
Bug-40982-bug-40753-follow-up-Adjust-conditions.patch (text/plain), 1.98 KB, created by
Jonathan Druart
on 2025-10-10 04:18:10 UTC
(
hide
)
Description:
Bug 40982: (bug 40753 follow-up) Adjust conditions
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-10 04:18:10 UTC
Size:
1.98 KB
patch
obsolete
>From c87a2ec2bda43bfae261829127ea152a1c1970af Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 10 Oct 2025 06:15:26 +0200 >Subject: [PATCH] Bug 40982: (bug 40753 follow-up) Adjust conditions > >The IF/ELSE block contents have been reversed in the JS code. >--- > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index f1fc81cf691..d0af80fbbbd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -1274,16 +1274,16 @@ > table_settings.columns.find(c => c.columnname == 'supplier_report').is_hidden = 0; > [% END %] > [% IF ( active && !closedate ) %] >+ table_settings.columns.find(c => c.columnname == 'modify').is_hidden = 0; >+ [% ELSE %] > table_settings.columns.find(c => c.columnname == 'modify').is_hidden = 1; > table_settings.columns.find(c => c.columnname == 'modify').cannot_be_toggled = 1; >- [% ELSE %] >- table_settings.columns.find(c => c.columnname == 'modify').is_hidden = 0; > [% END %] > [% IF !closedate || Koha.Preference('CancelOrdersInClosedBaskets') %] >- table_settings.columns.find(c => c.columnname == 'cancel').is_hidden = 1; >- table_settings.columns.find(c => c.columnname == 'modify').cannot_be_toggled = 1; >- [% ELSE %] > table_settings.columns.find(c => c.columnname == 'cancel').is_hidden = 0; >+ [% ELSE %] >+ table_settings.columns.find(c => c.columnname == 'cancel').is_hidden = 1; >+ table_settings.columns.find(c => c.columnname == 'cancel').cannot_be_toggled = 1; > [% END %] > > $("#orders").kohaTable({ >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40982
:
187651
|
187711
|
187712
|
187724
|
187726
|
187735
|
187736
|
187737
|
187738