Bugzilla – Attachment 187719 Details for
Bug 40978
t/db_dependent/Budgets.t fails on Debian 13 due to warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40978: Remove warnings from Budgets.t
Bug-40978-Remove-warnings-from-Budgetst.patch (text/plain), 1.12 KB, created by
Jonathan Druart
on 2025-10-10 09:16:12 UTC
(
hide
)
Description:
Bug 40978: Remove warnings from Budgets.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-10 09:16:12 UTC
Size:
1.12 KB
patch
obsolete
>From d1d0fc148a018c8249d50d93f9596deed85e405a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 10 Oct 2025 11:14:26 +0200 >Subject: [PATCH] Bug 40978: Remove warnings from Budgets.t > >If no shipment_budget is set then undef is set as key of the hashref >which generates a warning: > Use of uninitialized value $row[0] in hash element at /usr/lib/x86_64-linux-gnu/perl5/5.40/DBI.pm line 2122. > >Later we only access the hashref by budget_id, so this change seems >safe. >--- > C4/Budgets.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/Budgets.pm b/C4/Budgets.pm >index e36d1c74597..115ca14a867 100644 >--- a/C4/Budgets.pm >+++ b/C4/Budgets.pm >@@ -19,6 +19,7 @@ package C4::Budgets; > > use Modern::Perl; > use base 'Exporter'; >+ > BEGIN { > our @EXPORT_OK = qw( > >@@ -752,6 +753,7 @@ sub GetBudgetHierarchy { > SELECT shipmentcost_budgetid as budget_id, > SUM(shipmentcost) as shipmentcost > FROM aqinvoices >+ WHERE shipmentcost_budgetid IS NOT NULL > GROUP BY shipmentcost_budgetid > |, 'budget_id' > ); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40978
: 187719