Bugzilla – Attachment 187738 Details for
Bug 40982
Basket: Orders table — "Modify" and "Cancel order" columns missing or displayed incorrectly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40982: Do not raise Error when bKohaColumnsUseNames is not set
Bug-40982-Do-not-raise-Error-when-bKohaColumnsUseN.patch (text/plain), 1.39 KB, created by
Slava Shishkin
on 2025-10-10 14:02:30 UTC
(
hide
)
Description:
Bug 40982: Do not raise Error when bKohaColumnsUseNames is not set
Filename:
MIME Type:
Creator:
Slava Shishkin
Created:
2025-10-10 14:02:30 UTC
Size:
1.39 KB
patch
obsolete
>From 92c1ab4582d2d7ba7483afca61b57c61619a6aa9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 10 Oct 2025 12:25:58 +0200 >Subject: [PATCH] Bug 40982: Do not raise Error when bKohaColumnsUseNames is > not set > >Return early if there is no visibility to force > >Signed-off-by: Slava Shishkin <slavashishkin@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/js/datatables.js | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >index 68d135b4ec3..564dd831d32 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >@@ -953,12 +953,13 @@ function _dt_buttons(params) { > function _dt_force_visibility(table_settings, table_dt, state) { > var columns_settings = table_settings.columns; > let i = 0; >+ let force_vis_columns = table_settings.columns.filter( >+ c => c.force_visibility >+ ); >+ if (!force_vis_columns.length) return state; >+ > let use_names = $(table_dt.table().node()).data("bKohaColumnsUseNames"); > if (use_names) { >- let force_vis_columns = table_settings.columns.filter( >- c => c.force_visibility >- ); >- if (!force_vis_columns.length) return state; > table_dt > .columns( > force_vis_columns >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40982
:
187651
|
187711
|
187712
|
187724
|
187726
|
187735
|
187736
|
187737
| 187738