Bugzilla – Attachment 187882 Details for
Bug 20253
Optionally use buyer's purchase order number from EDIFACT quote in basket name
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20253: (follow-up) Update tests for Bug 38489 rebase
Bug-20253-follow-up-Update-tests-for-Bug-38489-reb.patch (text/plain), 7.28 KB, created by
Martin Renvoize (ashimema)
on 2025-10-14 10:58:21 UTC
(
hide
)
Description:
Bug 20253: (follow-up) Update tests for Bug 38489 rebase
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-10-14 10:58:21 UTC
Size:
7.28 KB
patch
obsolete
>From 705e6e0cf2893feef45392b125085cc8f7aadb8a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Wed, 1 Oct 2025 12:07:24 +0100 >Subject: [PATCH] Bug 20253: (follow-up) Update tests for Bug 38489 rebase > >With the move to Koha::File::Transports we need to update the tests >introduced in this patchset to match the others by generating a 'local' >transport and using that. >--- > t/db_dependent/Koha/EDI.t | 110 ++++++++++++++++++++++++++++---------- > 1 file changed, 81 insertions(+), 29 deletions(-) > >diff --git a/t/db_dependent/Koha/EDI.t b/t/db_dependent/Koha/EDI.t >index 0ff597a1eaf..a608dbae2d5 100755 >--- a/t/db_dependent/Koha/EDI.t >+++ b/t/db_dependent/Koha/EDI.t >@@ -816,18 +816,31 @@ subtest 'process_quote' => sub { > > $schema->storage->txn_begin; > >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Multiple Message Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > # Create vendor EDI account with po_is_basketname set to false (default) > my $account_filename = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'test vendor filename', >- transport => 'FILE', >- plugin => '', >- san => $test_san, >- quotes_enabled => 1, >- auto_orders => 0, >- po_is_basketname => 0, >+ description => 'test vendor filename', >+ file_transport_id => $file_transport->{file_transport_id}, >+ plugin => '', >+ san => $test_san, >+ quotes_enabled => 1, >+ auto_orders => 0, >+ po_is_basketname => 0, > } > } > ); >@@ -837,13 +850,13 @@ subtest 'process_quote' => sub { > { > source => 'VendorEdiAccount', > value => { >- description => 'test vendor purchase order', >- transport => 'FILE', >- plugin => '', >- san => $test_san, >- quotes_enabled => 1, >- auto_orders => 0, >- po_is_basketname => 1, >+ description => 'test vendor purchase order', >+ file_transport_id => $file_transport->{file_transport_id}, >+ plugin => '', >+ san => $test_san, >+ quotes_enabled => 1, >+ auto_orders => 0, >+ po_is_basketname => 1, > } > } > ); >@@ -920,14 +933,27 @@ subtest 'process_quote' => sub { > > $schema->storage->txn_begin; > >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Multiple Message Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > # Create vendor EDI account with po_is_basketname set to true > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'test vendor duplicate po', >- transport => 'FILE', >- po_is_basketname => 1, >+ description => 'test vendor duplicate po', >+ file_transport_id => $file_transport->{file_transport_id}, >+ po_is_basketname => 1, > }, > } > ); >@@ -1275,17 +1301,30 @@ subtest 'duplicate_po_number_blocking' => sub { > > $schema->storage->txn_begin; > >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Multiple Message Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > # Create vendor EDI account with auto_orders and po_is_basketname enabled > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'auto_orders duplicate test vendor', >- transport => 'FILE', >- plugin => '', >- san => $test_san, >- auto_orders => 1, >- po_is_basketname => 1, >+ description => 'auto_orders duplicate test vendor', >+ file_transport_id => $file_transport->{file_transport_id}, >+ plugin => '', >+ san => $test_san, >+ auto_orders => 1, >+ po_is_basketname => 1, > } > } > ); >@@ -1394,17 +1433,30 @@ subtest 'duplicate_po_number_blocking' => sub { > > $schema->storage->txn_begin; > >+ # Create file transport for local testing >+ my $file_transport = $builder->build( >+ { >+ source => 'FileTransport', >+ value => { >+ name => 'Test Multiple Message Transport', >+ transport => 'local', >+ download_directory => $dirname, >+ upload_directory => $dirname, >+ } >+ } >+ ); >+ > # Create vendor EDI account with po_is_basketname DISABLED > my $account = $builder->build( > { > source => 'VendorEdiAccount', > value => { >- description => 'feature disabled test vendor', >- transport => 'FILE', >- plugin => '', >- san => $test_san, >- auto_orders => 1, >- po_is_basketname => 0, # Feature disabled >+ description => 'feature disabled test vendor', >+ file_transport_id => $file_transport->{file_transport_id}, >+ plugin => '', >+ san => $test_san, >+ auto_orders => 1, >+ po_is_basketname => 0, # Feature disabled > } > } > ); >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20253
:
183859
|
183860
|
183861
|
183862
|
183953
|
183954
|
183955
|
183956
|
183957
|
183958
|
184000
|
184001
|
184002
|
184003
|
184004
|
184005
|
184006
|
184007
|
185221
|
185222
|
185223
|
185224
|
185225
|
185226
|
185227
|
185228
|
186860
|
186861
|
186862
|
186863
|
186864
|
186865
|
186866
|
186867
|
186868
|
186869
|
186870
|
186871
|
186872
|
186873
|
186874
|
186875
|
187165
|
187166
|
187167
|
187168
|
187169
|
187170
|
187171
|
187172
|
187173
|
187874
|
187875
|
187876
|
187877
|
187878
|
187879
|
187880
|
187881
| 187882 |
187883