Bugzilla – Attachment 187978 Details for
Bug 40272
Add an alert for incorrect (MARC21) fixed-length control fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40272: (QA follow-up) Only add a biblio test
Bug-40272-QA-follow-up-Only-add-a-biblio-test.patch (text/plain), 1.67 KB, created by
Marcel de Rooy
on 2025-10-16 09:15:13 UTC
(
hide
)
Description:
Bug 40272: (QA follow-up) Only add a biblio test
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-10-16 09:15:13 UTC
Size:
1.67 KB
patch
obsolete
>From 3e1fa0fe1c1a423050c5a9df9de0a56ec73599db Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 16 Oct 2025 11:09:39 +0200 >Subject: [PATCH] Bug 40272: (QA follow-up) Only add a biblio test >Content-Type: text/plain; charset=utf-8 > >And move the comment where it belongs. >More changes on 41031. > >Test plan: >Add a new biblio record with basic editor. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > cataloguing/addbiblio.pl | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index d7ec674e6e..a8e2720b5c 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -831,16 +831,14 @@ if ( $op eq "cud-addbiblio" ) { > > } else { > >- #---------------------------------------------------------------------------- >- # If we're in a duplication case, we have to set to "" the biblionumber >- # as we'll save the biblio as a new one. >- >- if ( C4::Context->preference('marcflavour') eq 'MARC21' ) { >+ if ( $biblio && C4::Context->preference('marcflavour') eq 'MARC21' ) { > my $fixed_length_info = >- Koha::Biblio::Metadata::Extractor::MARC::MARC21->new( { biblio => $biblio } )->check_fixed_length; >+ Koha::Biblio::Metadata::Extractor::MARC->new( { biblio => $biblio } )->check_fixed_length; > $template->param( marc21_fixlen => $fixed_length_info ) if @{ $fixed_length_info->{failed} }; > } > >+ # If we're in a duplication case, we have to set to "" the biblionumber >+ # as we'll save the biblio as a new one. > $template->param( > biblionumberdata => $biblionumber, > op => $op, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40272
:
183640
|
183641
|
186710
|
187959
|
187960
|
187961
| 187978