Bugzilla – Attachment 188053 Details for
Bug 40818
marc_lib is mostly used raw in templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40818: Remove HTML from marc_lib
Bug-40818-Remove-HTML-from-marclib.patch (text/plain), 2.38 KB, created by
Marcel de Rooy
on 2025-10-17 09:41:35 UTC
(
hide
)
Description:
Bug 40818: Remove HTML from marc_lib
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-10-17 09:41:35 UTC
Size:
2.38 KB
patch
obsolete
>From 7563581959a50664f2f8cbedc541e3495a892c44 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Oct 2025 09:25:41 +0200 >Subject: [PATCH] Bug 40818: Remove HTML from marc_lib >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/UI/Form/Builder/Item.pm | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 6 +----- > 2 files changed, 2 insertions(+), 6 deletions(-) > >diff --git a/Koha/UI/Form/Builder/Item.pm b/Koha/UI/Form/Builder/Item.pm >index c43483895d..033037d43d 100644 >--- a/Koha/UI/Form/Builder/Item.pm >+++ b/Koha/UI/Form/Builder/Item.pm >@@ -106,7 +106,7 @@ sub generate_subfield_form { > > $subfield_data{tag} = $tag; > $subfield_data{subfield} = $subfieldtag; >- $subfield_data{marc_lib} = "<span title=\"" . $subfield->{lib} . "\">" . $subfield->{lib} . "</span>"; >+ $subfield_data{marc_lib} = $subfield->{lib}; > $subfield_data{mandatory} = $subfield->{mandatory}; > $subfield_data{important} = $subfield->{important}; > $subfield_data{repeatable} = $subfield->{repeatable}; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >index 0fc0fcf040..064790a4ca 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >@@ -106,11 +106,7 @@ > > <li> > <div class="subfield_line" style="[% subfield.visibility | html %]" id="subfield[% subfield.tag | html %][% subfield.subfield | html %][% subfield.random | html %]"> >- [% IF ( subfield.mandatory ) %] >- <label class="required">[% subfield.subfield | html %] - [% subfield.marc_lib | $raw %]</label> >- [% ELSE %] >- <label>[% subfield.subfield | html %] - [% subfield.marc_lib | $raw %]</label> >- [% END %] >+ <label [% IF subfield.mandatory %]class="required"[% END %]>[% subfield.subfield | html %] - <span title="[% subfield.marc_lib | html %]">[% subfield.marc_lib | $raw %]</span></label> > > [% SET mv = subfield.marc_value %] > [% IF ( mv.type == 'hidden' ) %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40818
:
187503
|
187504
|
187782
|
187783
|
187784
| 188053 |
188054
|
188055
|
188140
|
188141
|
188531
|
188532