Bugzilla – Attachment 188097 Details for
Bug 39320
Create a 'landing page' for ERM
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39320: (QA follow-up): Fix counts links
Bug-39320-QA-follow-up-Fix-counts-links.patch (text/plain), 2.84 KB, created by
Pedro Amorim
on 2025-10-17 15:05:06 UTC
(
hide
)
Description:
Bug 39320: (QA follow-up): Fix counts links
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-10-17 15:05:06 UTC
Size:
2.84 KB
patch
obsolete
>From 6172c337a7ef584ebd3bfd0e05801eec68118d79 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Fri, 17 Oct 2025 09:48:02 +0000 >Subject: [PATCH] Bug 39320: (QA follow-up): Fix counts links > >Use router-link instead of href='#' >--- > .../ModuleDashboard/Widgets/ERMCounts.vue | 30 +++++++++---------- > 1 file changed, 15 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/Widgets/ERMCounts.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/Widgets/ERMCounts.vue >index 92ae98024ca..9f6350a18b3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/Widgets/ERMCounts.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/Widgets/ERMCounts.vue >@@ -8,23 +8,14 @@ > :key="index" > > > <strong> >- <a >+ <router-link > v-if="definition.page" >- href="#" >- @click.prevent="goToPage(definition.page)" >+ :to="{ name: definition.page }" > > >- {{ definition.count }} >- <span v-if="definition.count === 1">{{ >- definition.labelSingular >- }}</span> >- <span v-else>{{ definition.labelPlural }}</span> >- </a> >- <span v-else> >- {{ definition.count }} >- <span v-if="definition.count === 1">{{ >- definition.labelSingular >- }}</span> >- <span v-else>{{ definition.labelPlural }}</span> >+ {{ createCountText(definition) }} >+ </router-link> >+ <span v-else class="inactive-link"> >+ {{ createCountText(definition) }} > </span> > </strong> > <template v-if="index < countDefinitions.length - 1" >@@ -110,6 +101,14 @@ export default { > }, > ]); > >+ const createCountText = definition => { >+ if (definition.count === 1) { >+ return `${definition.count} ${definition.labelSingular}`; >+ } else { >+ return `${definition.count} ${definition.labelPlural}`; >+ } >+ }; >+ > async function getCounts() { > try { > const response = await APIClient.erm.counts.get(); >@@ -137,6 +136,7 @@ export default { > > return { > ...baseWidget, >+ createCountText, > countDefinitions, > goToPage, > }; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39320
:
187513
|
187514
|
187515
|
187516
|
187517
|
187518
|
187519
|
187520
|
187521
|
187522
|
187563
|
187568
|
187635
|
187636
|
187637
|
187638
|
187639
|
187640
|
187641
|
187642
|
187643
|
187644
|
187645
|
188094
|
188095
|
188096
|
188097
|
188098
|
188099
|
188100
|
188101
|
188102
|
188103
|
188104
|
188151
|
188279
|
188280
|
188281
|
188282
|
188283
|
188284
|
188285
|
188312
|
188315
|
188372
|
188375
|
188376
|
188637
|
188638
|
188639
|
188640
|
188641
|
188830
|
188831
|
188832
|
188833
|
188834
|
188835
|
188836
|
188837
|
188838
|
188839
|
188840
|
188841
|
188842
|
188843
|
188844
|
188845
|
188846
|
188847
|
188848
|
188849
|
188850
|
188851
|
188852
|
188853
|
188854
|
188855
|
188856
|
188857
|
188858
|
188859
|
188860
|
188861
|
188862
|
188863
|
188864