Bugzilla – Attachment 188269 Details for
Bug 29326
_ALL_ should not override other rules in UpdateItemLocationOnCheckin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29326: Add test for _BLANK_ key
Bug-29326-Add-test-for-BLANK-key.patch (text/plain), 1.45 KB, created by
Lari Taskula
on 2025-10-22 08:12:08 UTC
(
hide
)
Description:
Bug 29326: Add test for _BLANK_ key
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2025-10-22 08:12:08 UTC
Size:
1.45 KB
patch
obsolete
>From 3a161187eefed8bbbfa46ef76968037e57b44044 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Wed, 22 Oct 2025 11:01:00 +0300 >Subject: [PATCH] Bug 29326: Add test for _BLANK_ key > >To test: > >1. prove t/db_dependent/Koha/Item.t >2. Observe success >--- > t/db_dependent/Koha/Item.t | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index 19cdb04deac..c64c72e45fb 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -3356,7 +3356,7 @@ subtest 'current_branchtransfers relationship' => sub { > > subtest 'location_update_trigger() tests' => sub { > >- plan tests => 10; >+ plan tests => 12; > > $schema->storage->txn_begin; > >@@ -3394,6 +3394,12 @@ subtest 'location_update_trigger() tests' => sub { > $item->location_update_trigger($action); > is( $item->location, q{}, q{`_BLANK_` does the job} ); > >+ t::lib::Mocks::mock_preference( $pref, qq{_BLANK_: $location} ); >+ $item->location('')->store(); >+ >+ $item->location_update_trigger($action); >+ is( $item->location, $location, q{`_BLANK_` as the key does the job} ); >+ > t::lib::Mocks::mock_preference( $pref, qq{GEN: _BLANK_\n_BLANK_: PROC\n$location: _PERM_} ); > > $item->set( >@@ -3874,4 +3880,4 @@ subtest 'effective_bookable() tests' => sub { > ); > > $schema->storage->txn_rollback; >-}; >+}; >\ No newline at end of file >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29326
:
188043
| 188269 |
188270
|
188271
|
188272
|
188273
|
188274
|
188275
|
188276
|
188277
|
188278
|
189063