Bugzilla – Attachment 188273 Details for
Bug 29326
_ALL_ should not override other rules in UpdateItemLocationOnCheckin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29326: Fix _BLANK_ test failing
Bug-29326-Fix-BLANK-test-failing.patch (text/plain), 1.67 KB, created by
Lari Taskula
on 2025-10-22 08:25:25 UTC
(
hide
)
Description:
Bug 29326: Fix _BLANK_ test failing
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2025-10-22 08:25:25 UTC
Size:
1.67 KB
patch
obsolete
>From 51f99688cf56eb9989e5fc876839d3dc7a50a9d0 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Wed, 22 Oct 2025 11:07:00 +0300 >Subject: [PATCH] Bug 29326: Fix _BLANK_ test failing > >To test: >Before this patch: >1. prove t/db_dependent/Koha/Item.t >2. Observe failure >After this patch: >3. prove t/db_dependent/Koha/Item.t >4. Observe success >--- > Koha/Item.pm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 96a97f9f6d8..91d3e65e4a4 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -2783,7 +2783,8 @@ FIXME: It should return I<$self>. See bug 35270. > sub location_update_trigger { > my ( $self, $action ) = @_; > >- if (my $new_location = $self->_check_location_update_rules($action)) { >+ my $new_location = $self->_check_location_update_rules($action); >+ if (defined $new_location) { > my $messages = { > 'ItemLocationUpdated' => { > from => $self->location, >@@ -2815,8 +2816,8 @@ sub _check_location_update_rules { > if (defined($update_loc_rules->{'_ALL_'})) { > return $self->_check_location_update_rule($update_loc_rules->{'_ALL_'}); > } >- elsif (defined($update_loc_rules->{$self->location//''})) { >- return $self->_check_location_update_rule($update_loc_rules->{$self->location}); >+ elsif (defined($update_loc_rules->{$self->location||'_BLANK_'})) { >+ return $self->_check_location_update_rule($update_loc_rules->{$self->location||'_BLANK_'}); > } > elsif (defined($update_loc_rules->{'_DEFAULT_'})) { > return $self->_check_location_update_rule($update_loc_rules->{'_DEFAULT_'}); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29326
:
188043
|
188269
|
188270
|
188271
|
188272
| 188273 |
188274
|
188275
|
188276
|
188277
|
188278
|
189063