Bugzilla – Attachment 188308 Details for
Bug 41071
Registers not correctly populated / selected when changing branches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41071: Fix missing space in cash register classes
Bug-41071-Fix-missing-space-in-cash-register-class.patch (text/plain), 2.66 KB, created by
Jonathan Druart
on 2025-10-23 08:49:51 UTC
(
hide
)
Description:
Bug 41071: Fix missing space in cash register classes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-23 08:49:51 UTC
Size:
2.66 KB
patch
obsolete
>From 1cfa56c486ee5e33adb7afd901cff127d3784b84 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 22 Oct 2025 13:47:24 +0000 >Subject: [PATCH] Bug 41071: Fix missing space in cash register classes > >It seems we dropped a space somewhere so the class for default registers had become: > "{Branchcode}default" instead of "{Branchcode} default" >This broke the JS for selecting > >To test: >1 - Enable UseCashRegisters system preference >2 - Create three registers for three different branches >3 - Make each register the default >4 - Click on username in top right >5 - Select 'Set library and cash register' >6 - Choose on of the three branches >7 - Note the dropdown does not populate with the default >8 - Note no registers can be selected >9 - Apply patch >10 - Reload the page >11 - Change libraries and verify all works as expected > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >index 0fc0fcf0401..be0af14ce17 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >@@ -27,12 +27,12 @@ > [% FOREACH r IN registers %] > [% IF r.branch == Branches.GetLoggedInBranchcode %] > [% IF r.selected %] >- <option class="[%- r.branch | html -%][%- IF r.branch_default -%]default[%- END -%]" value="[% r.id | html %]" selected="selected">[% r.name | html %]</option> >+ <option class="[%- r.branch | html -%][%- IF r.branch_default -%][% ' ' | html %]default[%- END -%]" value="[% r.id | html %]" selected="selected">[% r.name | html %]</option> > [% ELSE %] >- <option class="[%- r.branch | html -%][%- IF r.branch_default -%]default[%- END -%]" value="[% r.id | html %]">[% r.name | html %]</option> >+ <option class="[%- r.branch | html -%][%- IF r.branch_default -%][% ' ' | html %]default[%- END -%]" value="[% r.id | html %]">[% r.name | html %]</option> > [% END %] > [% ELSE %] >- <option class="[%- r.branch | html -%][%- IF r.branch_default -%]default[%- END -%]" value="[% r.id | html %]" disabled="disabled" style="display: none">[% r.name | html %]</option> >+ <option class="[%- r.branch | html -%][%- IF r.branch_default -%][% ' ' | html %]default[%- END -%]" value="[% r.id | html %]" disabled="disabled" style="display: none">[% r.name | html %]</option> > [% END %] > [% END %] > [% END %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41071
:
188296
|
188297
| 188308