Bugzilla – Attachment 188321 Details for
Bug 41082
Renaming columns in reports doesn't work with batch tools
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41082: Fix batch tools from reports when itemnumber col has been renamed
Bug-41082-Fix-batch-tools-from-reports-when-itemnu.patch (text/plain), 4.00 KB, created by
Jonathan Druart
on 2025-10-23 10:41:18 UTC
(
hide
)
Description:
Bug 41082: Fix batch tools from reports when itemnumber col has been renamed
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-23 10:41:18 UTC
Size:
4.00 KB
patch
obsolete
>From 127cf12aec205176ad35957a1ab93a2569aeeae1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Oct 2025 12:40:08 +0200 >Subject: [PATCH] Bug 41082: Fix batch tools from reports when itemnumber col > has been renamed > >Description from comment 0 > >When creating an SQL report and it contains the column itemnumber, we >activate batch operations above the table. The itemnumber column can be >renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us >the option to translate the column name into something nicer for >display. > >But: if you then send to batch item edit, the items are not transmitted. > >Test plan: > >1) Create a report: >select itemnumber, itemcallnumber from items; > >2) Send some items to batch item edit, verify the items are shown above the item form > >3) Update the report: >select [[itemnumber|Exemplarnummer]], itemcallnumber from items; > >4) Verify the report still shows as before with the batch options available and only the column being renamed. > >5) Send some items to the batch item edit again > >=> verify the items are shown above the item form >--- > .../prog/en/modules/reports/guided_reports_start.tt | 4 ++-- > yarn.lock | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index aeb679955f6..b3ec9ad307c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1001,7 +1001,7 @@ > [% IF header_row.$place.cell == 'itemnumber' || header_types.item(header_row.$place.cell) == 'itemnumber' %] > [% SET batch_itemnumbers = 1 %] > [% SET header_row.$place.has_itemnumbers = 1 %] >- <input type="hidden" name="[% header_row.$place.cell | html %]" value="[% cells.cell | html %]" /> >+ <input type="hidden" name="itemnumber" value="[% cells.cell | html %]" /> > [% END %] > [% END %] > [% END %] >@@ -1018,7 +1018,7 @@ > [% IF header_row.$place.cell == 'itemnumber' || header_types.item(header_row.$place.cell) == 'itemnumber' %] > [% SET batch_itemnumbers = 1 %] > [% SET header_row.$place.has_itemnumbers = 1 %] >- <input type="hidden" name="[% header_row.$place.cell | html %]" value="[% cells.cell | html %]" /> >+ <input type="hidden" name="itemnumber" value="[% cells.cell | html %]" /> > [% END %] > [% END %] > [% END %] >diff --git a/yarn.lock b/yarn.lock >index 67917de85d1..b4a903ece7d 100755 >--- a/yarn.lock >+++ b/yarn.lock >@@ -12496,6 +12496,11 @@ vm-browserify@^1.0.0: > resolved "https://registry.yarnpkg.com/vm-browserify/-/vm-browserify-1.1.2.tgz#78641c488b8e6ca91a75f511e7a3b32a86e5dda0" > integrity sha512-2ham8XPWTONajOR0ohOKOHXkm3+gaBmGut3SRuu75xLd/RRaY6vqgh8NBYYk7+RW3u5AtzPQZG8F10LHkl0lAQ== > >+vue-draggable-next@^2.2.1: >+ version "2.3.0" >+ resolved "https://registry.yarnpkg.com/vue-draggable-next/-/vue-draggable-next-2.3.0.tgz#ba83154f60b8a3c24059c18b8060b72200a4c673" >+ integrity sha512-ymbY0UIwfSdg0iDN/iyNNwUrTqZ/6KbPryzsvTNXBLuDCuOBdNijSK8yynNtmiSj6RapTPQfjLGQdJrZkzBd2w== >+ > vue-eslint-parser@^9.4.3: > version "9.4.3" > resolved "https://registry.yarnpkg.com/vue-eslint-parser/-/vue-eslint-parser-9.4.3.tgz#9b04b22c71401f1e8bca9be7c3e3416a4bde76a8" >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41082
:
188321
|
188419
|
188523