Bugzilla – Attachment 188398 Details for
Bug 40017
Z39.50 search: Allow leader and specific control field positions in Additional fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40017: (QA follow-up) Fix t/db/Breeding.t
Bug-40017-QA-follow-up-Fix-tdbBreedingt.patch (text/plain), 1.60 KB, created by
Marcel de Rooy
on 2025-10-24 06:30:00 UTC
(
hide
)
Description:
Bug 40017: (QA follow-up) Fix t/db/Breeding.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-10-24 06:30:00 UTC
Size:
1.60 KB
patch
obsolete
>From d331970e841655e393d4bc431e9d1a15af547e23 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 24 Oct 2025 08:27:23 +0200 >Subject: [PATCH] Bug 40017: (QA follow-up) Fix t/db/Breeding.t >Content-Type: text/plain; charset=utf-8 > >Although t/Breeding.t was adjusted, the t/db counterpart should >have been adjusted too. >The sort order was added, the subfield tag was moved. > >Test plan: >Run test again. >--- > t/db_dependent/Breeding.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Breeding.t b/t/db_dependent/Breeding.t >index d2042a1c6e..c8c3fc31b5 100755 >--- a/t/db_dependent/Breeding.t >+++ b/t/db_dependent/Breeding.t >@@ -295,12 +295,12 @@ sub test_add_custom_field_rowdata { > > is( $returned_row->{title}, "Just a title", "_add_rowdata returns the title of a biblio" ); > is( >- $returned_row->{addnumberfields}[0], "245\$a", >+ $returned_row->{addnumberfields}[1], "245", > "_add_rowdata returns the field number chosen in the AdditionalFieldsInZ3950ResultSearch preference" > ); > >- # Test repeatble tags,the trailing whitespace is a normal side-effect of _add_custom_field_row_data >- is_deeply( \$returned_row->{"035\$a"}, \[ "First 035 ", "Second 035 " ], "_add_rowdata supports repeatable tags" ); >+ # Test repeatable tags >+ is_deeply( $returned_row->{"035"}, [ "[a]First 035", "[a]Second 035" ], "_add_rowdata supports repeatable tags" ); > > warning_is { C4::Breeding::_add_custom_field_rowdata( $row, $biblio, undef ) } undef, > 'no warn from add_custom_field_rowdata when pref_newtags undef'; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40017
:
182821
|
182902
|
182939
|
182940
|
187655
|
187656
|
188295
| 188398