Bugzilla – Attachment 188419 Details for
Bug 41082
Renaming columns in reports doesn't work with batch tools
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41082: Fix batch tools from reports when itemnumber col has been renamed
Bug-41082-Fix-batch-tools-from-reports-when-itemnu.patch (text/plain), 3.16 KB, created by
Owen Leonard
on 2025-10-24 16:29:44 UTC
(
hide
)
Description:
Bug 41082: Fix batch tools from reports when itemnumber col has been renamed
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-10-24 16:29:44 UTC
Size:
3.16 KB
patch
obsolete
>From dc485de92d3beeb2d2165220be5bd8d253407316 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 24 Oct 2025 16:25:44 +0000 >Subject: [PATCH] Bug 41082: Fix batch tools from reports when itemnumber col > has been renamed > >Description from comment 0 > >When creating an SQL report and it contains the column itemnumber, we >activate batch operations above the table. The itemnumber column can be >renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us >the option to translate the column name into something nicer for >display. > >But: if you then send to batch item edit, the items are not >transmitted. > >Test plan: > >1) Create a report: > select itemnumber, itemcallnumber from items; > >2) Send some items to batch item edit, verify the items are shown above > the item form > >3) Update the report: > select [[itemnumber|Exemplarnummer]], itemcallnumber from items; > >4) Verify the report still shows as before with the batch options > available and only the column being renamed. > >5) Send some items to the batch item edit again > > => verify the items are shown above the item form > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index aeb679955f6..b3ec9ad307c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1001,7 +1001,7 @@ > [% IF header_row.$place.cell == 'itemnumber' || header_types.item(header_row.$place.cell) == 'itemnumber' %] > [% SET batch_itemnumbers = 1 %] > [% SET header_row.$place.has_itemnumbers = 1 %] >- <input type="hidden" name="[% header_row.$place.cell | html %]" value="[% cells.cell | html %]" /> >+ <input type="hidden" name="itemnumber" value="[% cells.cell | html %]" /> > [% END %] > [% END %] > [% END %] >@@ -1018,7 +1018,7 @@ > [% IF header_row.$place.cell == 'itemnumber' || header_types.item(header_row.$place.cell) == 'itemnumber' %] > [% SET batch_itemnumbers = 1 %] > [% SET header_row.$place.has_itemnumbers = 1 %] >- <input type="hidden" name="[% header_row.$place.cell | html %]" value="[% cells.cell | html %]" /> >+ <input type="hidden" name="itemnumber" value="[% cells.cell | html %]" /> > [% END %] > [% END %] > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41082
:
188321
|
188419
|
188523