Bugzilla – Attachment 188436 Details for
Bug 41092
Some system preferences have target='blank' instead of target='_blank'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41092: Some system preferences have target='blank' instead of target='_blank'
Bug-41092-Some-system-preferences-have-targetblank.patch (text/plain), 8.95 KB, created by
David Nind
on 2025-10-24 23:26:51 UTC
(
hide
)
Description:
Bug 41092: Some system preferences have target='blank' instead of target='_blank'
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-10-24 23:26:51 UTC
Size:
8.95 KB
patch
obsolete
>From ecb4519407b1dba094f58823baf2a7f41346b21a Mon Sep 17 00:00:00 2001 >From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Date: Thu, 23 Oct 2025 15:05:03 -0400 >Subject: [PATCH] Bug 41092: Some system preferences have target='blank' > instead of target='_blank' > >This patch changes target='blank' to target='_blank' in system >preferences. > >To test: >1. Apply the patch >2. Check the following system preferences, click on the links, > make sure every click opens in a new tab > - UniqueItemFields > - PatronSelfModificationMandatoryField > - PatronSelfRegistrationBorrowerMandatoryField > - PatronSelfRegistrationBorrowerUnwantedField > - PatronSelfModificationBorrowerUnwantedField > - EmailFieldPrecedence > - BorrowerMandatoryField > - BorrowerUnwantedField > - PatronQuickAddFields > - PatronDuplicateMatchingAddFields > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: David Nind <david@davidnind.com> >--- > .../en/modules/admin/preferences/acquisitions.pref | 2 +- > .../prog/en/modules/admin/preferences/opac.pref | 8 ++++---- > .../prog/en/modules/admin/preferences/patrons.pref | 10 +++++----- > 3 files changed, 10 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref >index 7f1a886095..c8f8d395d2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref >@@ -9,7 +9,7 @@ Acquisitions: > cataloguing: cataloging the record. > - This is only the default behavior, and can be changed per-basket. > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/items.html' target='blank'>database columns</a> should be unique in an item:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/items.html' target='_blank'>database columns</a> should be unique in an item:" > - pref: UniqueItemFields > type: modalselect > source: items >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >index 8b4769c17e..37202dc17c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >@@ -844,19 +844,19 @@ OPAC: > - "days after account creation." > - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/cleanup_database.pl</code> cronjob. Ask your system administrator to schedule it.<br>No patrons will be deleted if you set the pref to zero or make it empty." > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron modification screen:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a> must be filled in on the patron modification screen:" > - pref: PatronSelfModificationMandatoryField > type: modalselect > source: borrowers > exclusions: password|cardnumber|dateexpiry|categorycode|sort1|sort2|opacnote|borrowernotes|gonenoaddress|lost|flags > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron entry screen:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a> must be filled in on the patron entry screen:" > - pref: PatronSelfRegistrationBorrowerMandatoryField > type: modalselect > source: borrowers > exclusions: sort1|sort2|opacnote|borrowernotes|gonenoaddress|lost|flags > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-registration screen:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a> will not appear on the patron self-registration screen:" > - pref: PatronSelfRegistrationBorrowerUnwantedField > type: modalselect > source: borrowers >@@ -864,7 +864,7 @@ OPAC: > inclusions: categorycode|dateexpiry > - '<br /> NOTE: preferred_name will be set to firstname if not included in the form.' > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-modification screen:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a> will not appear on the patron self-modification screen:" > - pref: PatronSelfModificationBorrowerUnwantedField > type: modalselect > source: borrowers >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >index eae4c9723f..533578e5b5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >@@ -213,7 +213,7 @@ Patrons: > - pref: EmailFieldPrecedence > class: multi > - '<br><strong>NOTE:</strong> All patron fields can be used, but to work correctly they must contain a valid email address or an empty string.' >- - "Valid options are the <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> of the borrowers table, separated by | (pipe)." >+ - "Valid options are the <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a> of the borrowers table, separated by | (pipe)." > - "Example: email|emailpro|B_email" > - > - "When <a href='/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=EmailFieldPrimary'>EmailFieldPrimary</a> is set to '<strong>selected addresses</strong>', send email to all valid email addresses in the selected fields:" >@@ -276,14 +276,14 @@ Patrons: > cron: (Deprecated) according to --send-notices cron switch > Patron forms: > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron entry screen:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a> must be filled in on the patron entry screen:" > - pref: BorrowerMandatoryField > type: modalselect > source: borrowers > exclusions: flags > - '<strong>NOTE:</strong> If <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=autoMemberNum">autoMemberNum</a> is enabled, the system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=BorrowerMandatoryField">BorrowerMandatoryField</a> must not contain the field <code>cardnumber</code>.' > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron entry screen:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a> will not appear on the patron entry screen:" > - pref: BorrowerUnwantedField > type: modalselect > source: borrowers >@@ -313,7 +313,7 @@ Patrons: > 0: "Don't" > - store and display surnames in upper case. > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a>:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a>:" > - pref: PatronQuickAddFields > type: modalselect > source: borrowers >@@ -339,7 +339,7 @@ Patrons: > messaging: "Patron messaging preferences" > - . > - >- - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a>:" >+ - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='_blank'>database columns</a>:" > - pref: PatronDuplicateMatchingAddFields > type: modalselect > source: borrowers >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41092
:
188393
|
188413
| 188436