Bugzilla – Attachment 188466 Details for
Bug 29768
hidepatronname hides guarantor name on borrower edit screen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29768: Do not hide guarantor name from memberentry.pl
0001-Bug-29768-Do-not-hide-guarantor-name-from-memberentr.patch (text/plain), 8.84 KB, created by
Emmi Takkinen
on 2025-10-27 10:07:47 UTC
(
hide
)
Description:
Bug 29768: Do not hide guarantor name from memberentry.pl
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2025-10-27 10:07:47 UTC
Size:
8.84 KB
patch
obsolete
>From 9a5ac12fdb69ece4c05d553e4bdcbaba219a46f6 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Mon, 25 Apr 2022 10:04:21 +0300 >Subject: [PATCH] Bug 29768: Do not hide guarantor name from memberentry.pl > >Syspref "hidepatronname" currently hides guarantors >name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff >can already see patrons other personal information >during edit. > >To test: >1) Disable syspref "hidepatronname" >2) Edit guarantee patrons information >=> Field "Guarantor" only shows guarantors cardnumber (or >is empty if guarantor has no cardnumber) >3) Apply patch >=> Guarantors name is now displayed (as a hyperlink) > >Also confirm hidepatronname still works as expected >on other pages (holds table, items detail page etc.). > >Sponsored-by: Koha-Suomi Oy >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 2 +- > .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 6 +++--- > .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +- > 5 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index 7b4ac6920f..670fa4ca90 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -269,7 +269,7 @@ > <li><a class="dropdown-item" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber | uri %]">Place hold</a></li> > <li > ><a class="dropdown-item" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber | uri %]&findborrower=[% holdfor_patron.cardnumber | uri %]" >- >Place hold for [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 %]</a >+ >Place hold for [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 no_html => 1 %]</a > ></li > > > </ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >index 7161ca7a3b..dbf7017349 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >@@ -47,7 +47,7 @@ > [%- SET display_patron_name = 0 -%] > [%- END -%] > [%- END -%] >-[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] >+[%- IF !no_html AND (display_patron_name OR display_cardnumber) -%] > [%- IF link_to == 'circulation_reserves' -%] > <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#reserves">[%- PROCESS display_patron_name -%]</a> > [%- ELSIF link_to == 'circulation_recalls' -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index c04479af86..42071b90e4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -165,9 +165,9 @@ > <ul class="dropdown-menu"> > <li><a href="#" class="placehold dropdown-item">Place hold</a></li> > [% IF holdfor %] >- <li><a href="#" class="placeholdfor dropdown-item">Place hold for [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 no_cardnumber => 1 %]</a></li> >+ <li><a href="#" class="placeholdfor dropdown-item">Place hold for [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 no_cardnumber => 1 no_html => 1 %]</a></li> > <li><hr class="dropdown-divider" /></li> >- <li><a class="dropdown-item" href="#" id="forgetholdfor">Forget [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 no_cardnumber => 1 %]</a></li> >+ <li><a class="dropdown-item" href="#" id="forgetholdfor">Forget [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 no_cardnumber => 1 no_html => 1 %]</a></li> > [% END %] > [% IF holdforclub %] > <li><a href="#" class="placeholdforclub dropdown-item">Place hold for [% holdforclub_name | html %]</a></li> >@@ -690,7 +690,7 @@ > <span class="holdforlink" > >| > <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]&findborrower=[% holdfor_patron.cardnumber | uri %]" >- >Place hold for [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 no_cardnumber => 1 %]</a >+ >Place hold for [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 no_cardnumber => 1 no_html => 1 %]</a > ></span > > > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 6a296dd8ff..175d012692 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -479,7 +479,7 @@ > [% IF patron_category.category_type == 'I' %] > <li class="guarantor-details" data-borrowernumber="[% r.guarantor_id | $raw %]"> > <span class="label">Organization:</span> >- [% INCLUDE 'patron-title.inc' patron=r.guarantor hide_patron_infos_if_needed=1 %] >+ [% INCLUDE 'patron-title.inc' patron=r.guarantor %] > </li> > <li> > <span class="label">Relationship:</span> >@@ -488,7 +488,7 @@ > [% ELSE %] > <li class="guarantor-details" data-borrowernumber="[% r.guarantor_id | $raw %]"> > <span class="label">Guarantor:</span> >- [% INCLUDE 'patron-title.inc' patron=r.guarantor hide_patron_infos_if_needed=1 %] >+ [% INCLUDE 'patron-title.inc' patron=r.guarantor %] > <input type="hidden" class="guarantor_id relation-[% r.id | html %]" name="guarantor_id" value="[% r.guarantor_id | html %]" /> > </li> > <li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index cf5f68b3e1..687394a3d1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -366,7 +366,7 @@ > <span class="holdforlink" > >| > <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% itemsloo.biblionumber | uri %]&findborrower=[% holdfor_patron.cardnumber | uri %]" >- >Place hold for [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 %]</a >+ >Place hold for [% INCLUDE 'patron-title.inc' patron => holdfor_patron no_title => 1 no_html => 1 %]</a > ></span > > > [% END %] >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29768
:
133542
|
133725
|
134806
|
134807
|
139180
|
139181
|
142606
|
142607
|
145220
| 188466