Bugzilla – Attachment 188517 Details for
Bug 41116
Selectors are inconsistently structured in hold found modals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41116: Standardize selectors in patron contact information in hold found modals
Bug-41116-Standardize-selectors-in-patron-contact-.patch (text/plain), 5.29 KB, created by
Andrew Fuerste-Henry
on 2025-10-28 14:45:00 UTC
(
hide
)
Description:
Bug 41116: Standardize selectors in patron contact information in hold found modals
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-10-28 14:45:00 UTC
Size:
5.29 KB
patch
obsolete
>From a73e862dd8449e33992f1e6fc397a53a48619f58 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Tue, 28 Oct 2025 14:31:03 +0000 >Subject: [PATCH] Bug 41116: Standardize selectors in patron contact > information in hold found modals > >This patch modifies both hold-found-modal and hold-found1. It adds a class to the patron phone number. For patron email, it changes the existing id to a class, expands the selector to include the bullet point in hold-found-modal, and standardizes the name (changing from "#boreamil' to ".patronemail"). > >To test: >1 - have a patron with both a phone number and an email address >2 - create a hold for your patron >3 - check an item in to fill your hold, triggering the hold-found-modal >4 - inspect the patron contact info, confirm there is no class on the phone number >5 - confirm there is an id on the patron email but it does not include the bullet point and is inconsistent with the names of other classes in the modal >6 - click Confirm Hold >7 - check your item in again, triggering the hold-found1 modal >8 - confirm there is no class on the patron phone number >9 - confirm there is an id on the patron email with an inconsistent name >10 - revert the waiting status of your hold >11 - apply patch, restart_all >12 - check your item in again, triggering hold-found-modal >13 - confirm the patron phone now has a class, .patronphone >14 - confirm the patron email now has a class, .patronemail, that the class includes the bullet point, and that the #boremail id has been removed >15 - click Confirm Hold >16 - check your item in again, triggering hold-found1 modal >17 - confirm the patron phone now has a class, .patronphone >18 - confirm the patron email now has a class, .patronemail, and that the #boremail id has been removed >--- > .../prog/en/modules/circ/returns.tt | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index eb71cb8dbc7..161a6380407 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -77,15 +77,15 @@ > [% INCLUDE display_holdpatron_address %] > > [% IF ( patron.phone ) %] >- <li>[% patron.phone | html %]</li> >+ <li class="patronphone">[% patron.phone | html %]</li> > [% END %] > > [% IF ( patron.email ) %] >- <li> >+ <li class="patronemail"> > [% IF ( transfertodo ) %] > [% patron.email | html %] > [% ELSE %] >- <a id="boremail" href="mailto:[% patron.email | html %]">[% patron.email | html %]</a> >+ <a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a> > [% END %] > </li> > [% END %] >@@ -695,10 +695,10 @@ > </li> > [% INCLUDE display_holdpatron_address %] > [% IF ( patron.phone ) %] >- <li> [% patron.phone | html %]</li> >+ <li class="patronphone"> [% patron.phone | html %]</li> > [% END %] > [% IF ( patron.email ) %] >- <li><a id="boremail" href="mailto:[% patron.email | html %]">[% patron.email | html %]</a></li> >+ <li class="patronemail"><a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a></li> > [% END %] > > [% IF ( patron.smsalertnumber ) %] >@@ -903,15 +903,15 @@ > [% INCLUDE display_holdpatron_address %] > > [% IF ( patron.phone ) %] >- <li>[% patron.phone | html %]</li> >+ <li class="patron-phone">[% patron.phone | html %]</li> > [% END %] > > [% IF ( patron.email ) %] >- <li> >+ <li class="patronemail"> > [% IF ( transfertodo ) %] > [% patron.email | html %] > [% ELSE %] >- <a id="boremail" href="mailto:[% patron.email | html %]">[% patron.email | html %]</a> >+ <a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a> > [% END %] > </li> > [% END %] >@@ -1008,7 +1008,7 @@ > [% INCLUDE display_holdpatron_address patron=recall.patron %] > > [% IF ( recall.patron.phone ) %] >- <li>[% recall.patron.phone | html %]</li> >+ <l >[% recall.patron.phone | html %]</li> > [% END %] > > [% IF ( recall.patron.email ) %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41116
: 188517