Attachment 18853 Details for Bug 10258 – Bug 10258: Remove erroneous call to haspermission in basket.pl

[patch] Bug 10258: Remove erroneous call to haspermission in basket.pl

Bug-10258-Remove-erroneous-call-to-haspermission-i.patch (text/plain), 1.82 KB, created by Jonathan Druart on 2013-06-11 15:18:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-06-11 15:18:26 UTC

Size: 1.82 KB

patch

obsolete

>From c1977dc8ab0a7a979c91bf35d1b1d130b355655e Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 16 May 2013 12:00:12 +0200
>Subject: [PATCH] Bug 10258: Remove erroneous call to haspermission in
> basket.pl
>
>First parameter (userid) was not passed making the test useless.
>Removed the test for now. Current behavior does not change.
>Just adding the first parameter here does not make sense. Using the permission
>here needs more than that.
>
>Test plan:
>Open a closed basket in Acquisition.
>Check if you see all available basketgroups in the combo at the right side.
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> acqui/basket.pl |    8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/acqui/basket.pl b/acqui/basket.pl
>index 7eff6e4..34e22c8 100755
>--- a/acqui/basket.pl
>+++ b/acqui/basket.pl
>@@ -207,8 +207,12 @@ if ( $op eq 'delete_confirm' ) {
>     }
> #if the basket is closed,and the user has the permission to edit basketgroups, display a list of basketgroups
>     my ($basketgroup, $basketgroups);
>-    my $member = GetMember(borrowernumber => $loggedinuser);
>-    if ($basket->{closedate} && haspermission({ acquisition => 'group_manage'} )) {
>+    # my $member = GetMember(borrowernumber => $loggedinuser);
>+    # FIXME $member is not used in current code (BZ 10258)
>+    # FIXME The following code should check the permission { acquisition => 'group_manage'}
>+    # Removed an invalid call to haspermission for now. No behavior change.
>+    # Only adding $member->{userid} is not the solution..
>+    if ($basket->{closedate}) {
>         $basketgroups = GetBasketgroups($basket->{booksellerid});
>         for my $bg ( @{$basketgroups} ) {
>             if ($basket->{basketgroupid} && $basket->{basketgroupid} == $bg->{id}){
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10258: 18166 | 18592 | 18736 | 18853 | 18944 | 19039 | 19053 | 19054 | 19648 | 19649