Bugzilla – Attachment 188566 Details for
Bug 40504
ILL requests should have ability to assign staff to manage
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40504: Preparation: Add empty_table_settings option to patron_search_js
Bug-40504-Preparation-Add-emptytablesettings-optio.patch (text/plain), 3.15 KB, created by
Pedro Amorim
on 2025-10-29 16:22:18 UTC
(
hide
)
Description:
Bug 40504: Preparation: Add empty_table_settings option to patron_search_js
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-10-29 16:22:18 UTC
Size:
3.15 KB
patch
obsolete
>From d72caa2297e6506aafa326743e716f606d167182 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Wed, 15 Oct 2025 09:06:29 +0000 >Subject: [PATCH] Bug 40504: Preparation: Add empty_table_settings option to > patron_search_js > >This is required for ILL 'select manager' functionality, as table_settings are already defined there and the user modal table will pick that up unless explicitly stated to not use it, thus empty_table_settings > >Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 5 ++++- > koha-tmpl/intranet-tmpl/prog/en/includes/select_manager.inc | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index a4f76e8e116..8521528b9df 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -236,6 +236,7 @@ > [%# display_search_description: boolean, default off. Display the description of the search %] > [%# adjust_history: boolean, default off. Change the current url when a first letter is selected %] > [%# defer_loading: boolean, default on. If true, it will not load the table until a search is triggered %] >+[%# empty_table_settings: boolean, default off. If true, it will ensure no table_settings are utilized %] > [% BLOCK patron_search_js %] > > [% IF redirect_if_one_result && !redirect_url %] >@@ -285,6 +286,8 @@ > return map; > }, {}); > >+ var empty_table_settings = '[% empty_table_settings | html %]' >+ > [% IF Koha.Preference('ExtendedPatronAttributes') %] > [% SET extended_attribute_types = ExtendedAttributeTypes.codes( staff_searchable => 1, searched_by_default => 1 ) %] > [% IF ( extended_attribute_types ) %][% extended_attribute_types = [ extended_attribute_types ] %][% END %] >@@ -783,7 +786,7 @@ > }, > [% END %] > fixedHeader: false, >- }, typeof table_settings !== 'undefined' ? table_settings : null, 1, additional_filters, undefined, external_filter_nodes, parent_block.find(".search_description"), additional_search_descriptions ); >+ }, typeof table_settings !== 'undefined' && !empty_table_settings ? table_settings : null, 1, additional_filters, undefined, external_filter_nodes, parent_block.find(".search_description"), additional_search_descriptions ); > > patron_search_form.on('submit', filter); > patron_search_form.on('submit', update_search_type); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/select_manager.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/select_manager.inc >index 6a40a310a9b..a2fe25ea513 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/select_manager.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/select_manager.inc >@@ -14,6 +14,7 @@ > preview_on_name_click => 1, > table_id => 'patron_search_modal_manager_table', > callback => 'select_manager' >+ empty_table_settings => 1 > %] > [% END %] > <script> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40504
:
187906
|
187907
|
187908
|
187909
|
187910
|
187911
|
187912
|
187913
|
187914
|
187915
|
188365
|
188563
|
188565
| 188566 |
188567
|
188568
|
188569
|
188570
|
188571
|
188572
|
188573
|
188574
|
188624
|
188625
|
188935
|
188936