Bugzilla – Attachment 188625 Details for
Bug 40504
ILL requests should have ability to assign staff to manage
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40504: (QA follow-up): Add 'managed by' filter
Bug-40504-QA-follow-up-Add-managed-by-filter.patch (text/plain), 2.88 KB, created by
Pedro Amorim
on 2025-10-30 11:20:54 UTC
(
hide
)
Description:
Bug 40504: (QA follow-up): Add 'managed by' filter
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-10-30 11:20:54 UTC
Size:
2.88 KB
patch
obsolete
>From 07798ab60f5782b175ddda5d8fc66e70ce88d7b6 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 30 Oct 2025 11:18:21 +0000 >Subject: [PATCH] Bug 40504: (QA follow-up): Add 'managed by' filter > >This adds a 'Managed by:' filter input on the left side filters. >--- > .../intranet-tmpl/prog/en/includes/ill-filter.inc | 4 ++++ > koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 10 ++++++++++ > 2 files changed, 14 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-filter.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-filter.inc >index 8c4e48530aa..4eb7181a472 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-filter.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-filter.inc >@@ -48,6 +48,10 @@ > <label for="illfilter_patron">Patron:</label> > <input type="text" name="illfilter_patron" id="illfilter_patron" /> > </li> >+ <li> >+ <label for="illfilter_managed_by">Managed by:</label> >+ <input type="text" name="illfilter_managed_by" id="illfilter_managed_by" /> >+ </li> > </ol> > </fieldset> > <fieldset class="action"> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >index 81a7a841d03..314c9cf257e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >@@ -159,6 +159,7 @@ $(document).ready(function () { > }, > "-or": function () { > let patron = $("#illfilter_patron").val(); >+ let managed_by = $("#illfilter_managed_by").val(); > let status = $("#illfilter_status").val(); > let status_alias = $("#illfilter_status_alias").val(); > let filters = []; >@@ -174,6 +175,13 @@ $(document).ready(function () { > subquery_and.push(patronquery); > } > >+ if (managed_by) { >+ let managed_byquery = buildPatronSearchQuery(managed_by, { >+ table_prefix: "manager", >+ }); >+ subquery_and.push(managed_byquery); >+ } >+ > if (status && status.length > 0) { > subquery_and.push({ "me.status": { "=": status } }); > } >@@ -270,6 +278,7 @@ $(document).ready(function () { > illfilter_datemodified_end: "#illfilter_datemodified_end", > illfilter_branchname: "#illfilter_branchname", > illfilter_patron: "#illfilter_patron", >+ illfilter_managed_by: "#illfilter_managed_by", > }; > > let table_id = "#ill-requests"; >@@ -586,6 +595,7 @@ $(document).ready(function () { > "illfilter_backend", > "illfilter_branchname", > "illfilter_patron", >+ "illfilter_managed_by", > "illfilter_keyword", > ]; > filters.forEach(filter => { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40504
:
187906
|
187907
|
187908
|
187909
|
187910
|
187911
|
187912
|
187913
|
187914
|
187915
|
188365
|
188563
|
188565
|
188566
|
188567
|
188568
|
188569
|
188570
|
188571
|
188572
|
188573
|
188574
|
188624
|
188625
|
188935
|
188936