Bugzilla – Attachment 188653 Details for
Bug 40720
Misleading title attribute "Remove all items" in Select2 fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40720: Misleading title attribute "Remove all items" in Select2 fields
Bug-40720-Misleading-title-attribute-Remove-all-it.patch (text/plain), 1.75 KB, created by
Laura Escamilla
on 2025-10-30 13:35:55 UTC
(
hide
)
Description:
Bug 40720: Misleading title attribute "Remove all items" in Select2 fields
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2025-10-30 13:35:55 UTC
Size:
1.75 KB
patch
obsolete
>From a96c10518d918044883a830a90f0d590bac4f266 Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Tue, 28 Oct 2025 17:01:53 +0200 >Subject: [PATCH] Bug 40720: Misleading title attribute "Remove all items" in > Select2 fields > >This patch updates our Select2 initialization script to update the >strings used as title attributes on the "X" control which appears in a >Select2 dropdown when you've made a selection. > >The updated text reads "Clear selections" in order to eliminate the >ambiguity of the word "items." > >To test, apply the patch and clear your browser cache. > >- Go to Catalog -> Item search. >- Make one or more selections in any of the Select2 dropdowns (e.g. Home > library, current library, item type, etc.). >- An "X" should appear at the end of the field after you've made one or > more selections. >- Hover your mouse over the "X." The title which appears should read > "Clear selections." > >Sponsored-by: Athens County Public Libraries > >Signed-off-by: Slava Shishkin <slavashishkin@gmail.com> >Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/js/select2.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/select2.js b/koha-tmpl/intranet-tmpl/prog/js/select2.js >index 5e585ab2d8..b3b5722ebd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/select2.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/select2.js >@@ -32,10 +32,10 @@ $.fn.select2.defaults.set("language", { > return __("Searchingâ¦"); > }, > removeAllItems: function () { >- return __("Remove all items"); >+ return __("Clear selections"); > }, > removeItem: function () { >- return __("Remove item"); >+ return __("Clear selection"); > }, > }); > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40720
:
188513
|
188518
|
188519
| 188653