Bugzilla – Attachment 188668 Details for
Bug 41055
Missing accesskey attribute for print button (shortcut P)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41055: add missing accesskey attribute for print button
Bug-41055-add-missing-accesskey-attribute-for-prin.patch (text/plain), 2.71 KB, created by
Slava Shishkin
on 2025-10-30 16:11:07 UTC
(
hide
)
Description:
Bug 41055: add missing accesskey attribute for print button
Filename:
MIME Type:
Creator:
Slava Shishkin
Created:
2025-10-30 16:11:07 UTC
Size:
2.71 KB
patch
obsolete
>From 33b823dec5c995e94100a0403cc4c79226459b82 Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Thu, 30 Oct 2025 18:10:01 +0200 >Subject: [PATCH] Bug 41055: add missing accesskey attribute for print button > >This commit adds the missing accesskey attribute to the print button in the circulation template. > >Test plan: >1. Try to checkout an item that is waiting for pickup. >2. Try to print the checkout receipt using the alt+shift+p keyboard shortcut. >3. Verify that nothing happens when using the shortcut. >4. After applying this commit, try the same steps again. >5. Verify that the print button now works with the alt+shift+p keyboard shortcut. > >Sponsored-by: Koha-Suomi Oy > >Signed-off-by: Slava Shishkin <slavashishkin@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 8872479a71e..45612cd5aaf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -493,7 +493,7 @@ > <input type="hidden" name="hold_borrower" value="[% resborrowernumber | html %]" /> > <input type="hidden" name="hold_itemnumber" value="[% item.itemnumber | html %]" /> > <input type="hidden" name="stickyduedate" value="[% stickyduedate | html %]" /> >- <button class="btn btn-default print" type="submit" onclick="Dopop('hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]&itemnumber=[% item.id | html %]');this.form.submit();" >+ <button class="btn btn-default print" type="submit" accesskey="p" onclick="Dopop('hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]&itemnumber=[% item.id | html %]');this.form.submit();" > ><i class="fa fa-print"></i> Don't check out, confirm hold, and print slip (P)</button > > > </form> >@@ -501,7 +501,7 @@ > > [% IF ( RECALLED ) %] > <form method="get" action="/cgi-bin/koha/circ/circulation.pl"> >- <button class="btn btn-default print" type="submit" onclick="Dopop('/cgi-bin/koha/recalls/recall_pickup_slip.pl?recall_id=[% RECALLED.id | html %]');this.form.submit();" >+ <button class="btn btn-default print" type="submit" accesskey="p" onclick="Dopop('/cgi-bin/koha/recalls/recall_pickup_slip.pl?recall_id=[% RECALLED.id | html %]');this.form.submit();" > ><i class="fa fa-print"></i> Don't check out and print slip (P)</button > > > </form> >-- >2.51.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41055
:
188158
| 188668