Bugzilla – Attachment 188707 Details for
Bug 27115
Restarting koha-common fails to restart SIP2 server
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27115: Use start-stop-daemon to stop in koha-sip
Bug-27115-Use-start-stop-daemon-to-stop-in-koha-si.patch (text/plain), 2.96 KB, created by
Lari Taskula
on 2025-10-30 22:09:09 UTC
(
hide
)
Description:
Bug 27115: Use start-stop-daemon to stop in koha-sip
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2025-10-30 22:09:09 UTC
Size:
2.96 KB
patch
obsolete
>From c1e24c06628b48ba9837e68b56f5dd417e4683de Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Thu, 30 Oct 2025 22:57:20 +0200 >Subject: [PATCH] Bug 27115: Use start-stop-daemon to stop in koha-sip > >There has been an issue where a restart of koha-sip would sometimes not bring >the SIP server back alive. This is because we have not been waiting for >koha-sip --stop to actually stop the SIP server(s). It is then possible for a >restart to attempt the --start command while a previous instance of SIP server >is still running. As the --start command in this case is not allowed, we would >then end up not starting the SIP server(s) at all. > >This patch replaces daemon --stop with start-stop-daemon --stop to ensure >koha-sip daemon actually stops. > >start-stop-daemon provides us the --retry option, which we are able to utilize >in waiting for the stop process to finish. > >To test: >1. Before applying this patch >2. Run this command > >export SIPINSTANCE="your_koha_instance_name" > >You can your_koha_instance_name using the koha-list command > >3. Configure a SIP server (add some min_servers, e.g. 6, to SIPConfig.xml) >4. koha-sip --enable $SIPINSTANCE >5. koha-sip --verbose --start $SIPINSTANCE >6. Observe "Starting SIP server for ..." >7. koha-sip --verbose --stop $SIPINSTANCE; ps aux | grep $SIPINSTANCE-koha-sip >8. Observe "Stopping SIP server for instancename" >9. In the output, observe the number of SIP servers you defined in step 3, plus > one. >10. koha-sip --verbose --start $SIPINSTANCE >11. Apply this patch, or edit the koha-sip directly to get changes in place >in your environment, e.g. using command > >nano $(which koha-sip) > >12. koha-sip --verbose --stop $SIPINSTANCE; ps aux | grep $SIPINSTANCE-koha-sip >13. Observe "Stopping SIP server for instancename" >14. In the output, observe no more SIP servers alive >--- > debian/scripts/koha-sip | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > >diff --git a/debian/scripts/koha-sip b/debian/scripts/koha-sip >index df80313f426..73f56a03165 100755 >--- a/debian/scripts/koha-sip >+++ b/debian/scripts/koha-sip >@@ -112,22 +112,14 @@ start_sip() > stop_sip() > { > local name=$1 >+ local PIDFILE="/var/run/koha/${name}/${name}-koha-sip.pid" > > if is_sip_running $name; then > >- DAEMONOPTS="--name=${name}-koha-sip \ >- --errlog=/var/log/koha/${name}/sip-error.log \ >- --output=/var/log/koha/${name}/sip-output.log \ >- --verbose=1 \ >- --respawn \ >- --delay=30 \ >- --pidfiles=/var/run/koha/${name} \ >- --user=${name}-koha.${name}-koha" >- > [ "$verbose" != "no" ] && \ > log_daemon_msg "Stopping SIP server for ${name}" > >- if daemon $DAEMONOPTS --stop; then >+ if start-stop-daemon --pidfile $PIDFILE --user ${name}-koha --stop --retry=TERM/30/KILL/5; then > ([ "$verbose" != "no" ] && \ > log_end_msg 0) || return 0 > else >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27115
: 188707