Bugzilla – Attachment 188731 Details for
Bug 39860
Add a way to allow for additional/custom MARC fields in the record display
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39860: (QA follow-up) fix XSS vulnerability and fix disabling of WYSIWYG
Bug-39860-QA-follow-up-fix-XSS-vulnerability-and-f.patch (text/plain), 3.83 KB, created by
David Cook
on 2025-10-31 02:20:22 UTC
(
hide
)
Description:
Bug 39860: (QA follow-up) fix XSS vulnerability and fix disabling of WYSIWYG
Filename:
MIME Type:
Creator:
David Cook
Created:
2025-10-31 02:20:22 UTC
Size:
3.83 KB
patch
obsolete
>From a58f546bed444070a8c3af88c837eaa06fddb7d3 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 31 Oct 2025 02:17:57 +0000 >Subject: [PATCH] Bug 39860: (QA follow-up) fix XSS vulnerability and fix > disabling of WYSIWYG > >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > .../prog/en/modules/tools/additional-contents.tt | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >index 06172b3b5e5..68eea231805 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >@@ -3,6 +3,7 @@ > [% USE Koha %] > [% USE KohaDates %] > [% USE Branches %] >+[% USE HtmlScrubber %] > [% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >@@ -351,7 +352,7 @@ > ><button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false"> </button> > <ul class="dropdown-menu"> > <li> >- [% IF ( wysiwy || category == 'record_display' ) %] >+ [% IF ( wysiwyg || category == 'record_display' ) %] > <a class="dropdown-item" href="/cgi-bin/koha/tools/additional-contents.pl?op=add_form&category=[% category | uri %]&editmode=text">New entry using text editor</a> > [% ELSE %] > <a class="dropdown-item" href="/cgi-bin/koha/tools/additional-contents.pl?op=add_form&category=[% category | uri %]&editmode=wysiwyg">New entry using WYSIWYG editor</a> >@@ -468,7 +469,11 @@ > <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> > </div> > <div class="modal-body"> >- <template shadowrootmode="open"> [% default_localization.content | $raw %] </template> >+ [% IF ( category == 'record_display' ) %] >+ <template shadowrootmode="open"> [% default_localization.content | scrub_html type => 'record_display' | $raw %] </template> >+ [% ELSE %] >+ <template shadowrootmode="open"> [% default_localization.content | $raw %] </template> >+ [% END %] > </div> > <div class="modal-footer"> > <button type="button" class="btn btn-default" data-bs-dismiss="modal">Close</button> >@@ -483,7 +488,7 @@ > ><button class="btn btn-default btn-xs dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false"> </button> > <ul class="dropdown-menu"> > <li> >- [% IF ( wysiwyg ) %] >+ [% IF ( wysiwyg || category == 'record_display' ) %] > <a class="dropdown-item" href="/cgi-bin/koha/tools/additional-contents.pl?op=add_form&id=[% c.id | uri %]&editmode=text"><i class="fa-solid fa-pencil"></i> Edit with text editor</a> > [% ELSE %] > <a class="dropdown-item" href="/cgi-bin/koha/tools/additional-contents.pl?op=add_form&id=[% c.id | uri %]&editmode=wysiwyg" >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39860
:
182054
|
182055
|
182056
|
182057
|
182058
|
182059
|
182230
|
182231
|
182232
|
182233
|
183007
|
183008
|
183009
|
183010
|
183011
|
183035
|
183077
|
183095
|
183774
|
185835
|
185865
|
185866
|
185867
|
185868
|
185869
|
185870
|
185900
|
185901
|
185902
|
185903
|
185904
|
185905
|
187898
|
188724
|
188725
|
188726
|
188727
|
188728
|
188729
|
188730
| 188731